wip: remove derefs

NickLarsenNZ · NickLarsenNZ · commit 7b80f17a3edc · 2025-01-28T16:44:39.000+01:00
diff --git a/crates/stackable-telemetry/src/tracing/settings/console_log.rs b/crates/stackable-telemetry/src/tracing/settings/console_log.rs
@@ -1,7 +1,5 @@
 //! Console Log Subscriber Settings.
 
-use std::ops::Deref;
-
 use tracing::level_filters::LevelFilter;
 
 use super::{Settings, SettingsBuilder, SettingsToggle};
@@ -51,14 +49,6 @@ impl SettingsToggle for ConsoleLogSettings {
     }
 }
 
-// impl Deref for ConsoleLogSettings {
-//     type Target = Settings;
-
-//     fn deref(&self) -> &Self::Target {
-//         &self.common_settings
-//     }
-// }
-
 /// For building [`ConsoleLogSettings`].
 ///
 /// <div class="warning">
diff --git a/crates/stackable-telemetry/src/tracing/settings/file_log.rs b/crates/stackable-telemetry/src/tracing/settings/file_log.rs
@@ -1,6 +1,6 @@
 //! File Log Subscriber Settings.
 
-use std::{ops::Deref, path::PathBuf};
+use std::path::PathBuf;
 
 use super::{Settings, SettingsToggle};
 
@@ -31,14 +31,6 @@ impl SettingsToggle for FileLogSettings {
     }
 }
 
-// impl Deref for FileLogSettings {
-//     type Target = Settings;
-
-//     fn deref(&self) -> &Self::Target {
-//         &self.common_settings
-//     }
-// }
-
 /// For building [`FileLogSettings`].
 ///
 /// <div class="warning">
diff --git a/crates/stackable-telemetry/src/tracing/settings/otlp_log.rs b/crates/stackable-telemetry/src/tracing/settings/otlp_log.rs
@@ -1,7 +1,5 @@
 //! OTLP Log Subscriber Settings.
 
-use std::ops::Deref;
-
 use tracing::level_filters::LevelFilter;
 
 use super::{Settings, SettingsBuilder, SettingsToggle};
@@ -28,14 +26,6 @@ impl SettingsToggle for OtlpLogSettings {
     }
 }
 
-// impl Deref for OtlpLogSettings {
-//     type Target = Settings;
-
-//     fn deref(&self) -> &Self::Target {
-//         &self.common_settings
-//     }
-// }
-
 pub struct OtlpLogSettingsBuilder {
     pub(crate) common_settings: Settings,
 }
diff --git a/crates/stackable-telemetry/src/tracing/settings/otlp_trace.rs b/crates/stackable-telemetry/src/tracing/settings/otlp_trace.rs
@@ -1,7 +1,5 @@
 //! OTLP Trace Subscriber Settings.
 
-use std::ops::Deref;
-
 use tracing::level_filters::LevelFilter;
 
 use super::{Settings, SettingsBuilder, SettingsToggle};
@@ -28,14 +26,6 @@ impl SettingsToggle for OtlpTraceSettings {
     }
 }
 
-// impl Deref for OtlpTraceSettings {
-//     type Target = Settings;
-
-//     fn deref(&self) -> &Self::Target {
-//         &self.common_settings
-//     }
-// }
-
 pub struct OtlpTraceSettingsBuilder {
     pub(crate) common_settings: Settings,
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`//! OTLP Log Subscriber Settings.`
`2`	`2`
`3`		`-use std::ops::Deref;`
`4`		`-`
`5`	`3`	`use tracing::level_filters::LevelFilter;`
`6`	`4`
`7`	`5`	`use super::{Settings, SettingsBuilder, SettingsToggle};`
`@@ -28,14 +26,6 @@ impl SettingsToggle for OtlpLogSettings {`
`28`	`26`	`}`
`29`	`27`	`}`
`30`	`28`
`31`		`-// impl Deref for OtlpLogSettings {`
`32`		`-// type Target = Settings;`
`33`		`-`
`34`		`-// fn deref(&self) -> &Self::Target {`
`35`		`-// &self.common_settings`
`36`		`-// }`
`37`		`-// }`
`38`		`-`
`39`	`29`	`pub struct OtlpLogSettingsBuilder {`
`40`	`30`	`pub(crate) common_settings: Settings,`
`41`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`//! OTLP Trace Subscriber Settings.`
`2`	`2`
`3`		`-use std::ops::Deref;`
`4`		`-`
`5`	`3`	`use tracing::level_filters::LevelFilter;`
`6`	`4`
`7`	`5`	`use super::{Settings, SettingsBuilder, SettingsToggle};`
`@@ -28,14 +26,6 @@ impl SettingsToggle for OtlpTraceSettings {`
`28`	`26`	`}`
`29`	`27`	`}`
`30`	`28`
`31`		`-// impl Deref for OtlpTraceSettings {`
`32`		`-// type Target = Settings;`
`33`		`-`
`34`		`-// fn deref(&self) -> &Self::Target {`
`35`		`-// &self.common_settings`
`36`		`-// }`
`37`		`-// }`
`38`		`-`
`39`	`29`	`pub struct OtlpTraceSettingsBuilder {`
`40`	`30`	`pub(crate) common_settings: Settings,`
`41`	`31`	`}`