File tree Expand file tree Collapse file tree 1 file changed +6
-1
lines changed
crates/stackable-operator/src/commons/s3 Expand file tree Collapse file tree 1 file changed +6
-1
lines changed Original file line number Diff line number Diff line change @@ -79,6 +79,9 @@ impl ResolvedS3Connection {
79
79
///
80
80
/// * Credentials needed to connect to S3
81
81
/// * Needed TLS volumes
82
+ ///
83
+ /// `unique_identifier` needs to be a unique identifier (e.g. in case of trino-operator the name of the catalog),
84
+ /// so that multiple mounts of the same SecretClass do not produce clashing volumes and volumeMounts.
82
85
pub fn add_volumes_and_mounts (
83
86
& self ,
84
87
unique_identifier : & str ,
@@ -134,6 +137,9 @@ impl ResolvedS3Connection {
134
137
135
138
/// Returns the path of the files containing bind user and password.
136
139
/// This will be None if there are no credentials for this LDAP connection.
140
+ ///
141
+ /// `unique_identifier` needs to be a unique identifier (e.g. in case of trino-operator the name of the catalog),
142
+ /// so that multiple mounts of the same SecretClass do not produce clashing volumes and volumeMounts.
137
143
pub fn credentials_mount_paths ( & self , unique_identifier : & str ) -> Option < ( String , String ) > {
138
144
self . credentials . as_ref ( ) . map ( |bind_credentials| {
139
145
let secret_class = & bind_credentials. secret_class ;
@@ -199,7 +205,6 @@ mod test {
199
205
use super :: * ;
200
206
201
207
// We cant test the correct resolve, as we can't mock the k8s API.
202
-
203
208
#[ test]
204
209
fn test_http ( ) {
205
210
let s3 = ResolvedS3Connection {
You can’t perform that action at this time.
0 commit comments