refactor: Replace lazy_static with std::sync::LazyLock

std::cell::LazyCell and std::sync::LazyLock were
stabilized in Rust 1.80.0. We can now use the
standard library types instead of the lazy_static
crate.

Author: Techassi

Cargo.lock

@@ -32,7 +32,6 @@ json-patch = "2.0.0"
 k8s-openapi = { version = "0.22.0", default-features = false, features = ["schemars", "v1_30"] }
 # We use rustls instead of openssl for easier portablitly, e.g. so that we can build stackablectl without the need to vendor (build from source) openssl
 kube = { version = "0.92.1", default-features = false, features = ["client", "jsonpatch", "runtime", "derive", "rustls-tls"] }
-lazy_static = "1.5.0"
 opentelemetry = "0.23.0"
 opentelemetry_sdk = { version = "0.23.0", features = ["rt-tokio"] }
 opentelemetry-appender-tracing = "0.4.0"

Cargo.toml

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Changed
+
+- Replace `lazy_static` with `std::cell::LazyCell` ([#xxx]).
+
+[#xxx](https://github.com/stackabletech/operator-rs/pull/xxx)
+
 ## [0.1.1] - 2024-07-10
 
 ### Changed

crates/k8s-version/CHANGELOG.md

@@ -11,7 +11,6 @@ darling = ["dep:darling"]
 
 [dependencies]
 darling = { workspace = true, optional = true }
-lazy_static.workspace = true
 regex.workspace = true
 snafu.workspace = true
 

crates/k8s-version/Cargo.toml

@@ -1,16 +1,14 @@
-use std::{fmt, ops::Deref, str::FromStr};
+use std::{fmt, ops::Deref, str::FromStr, sync::LazyLock};
 
-use lazy_static::lazy_static;
 use regex::Regex;
 use snafu::{ensure, Snafu};
 
 const MAX_GROUP_LENGTH: usize = 253;
 
-lazy_static! {
-    static ref API_GROUP_REGEX: Regex =
-        Regex::new(r"^(?:(?:[a-z0-9][a-z0-9-]{0,61}[a-z0-9])\.?)+$")
-            .expect("failed to compile API group regex");
-}
+static API_GROUP_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new(r"^(?:(?:[a-z0-9][a-z0-9-]{0,61}[a-z0-9])\.?)+$")
+        .expect("failed to compile API group regex")
+});
 
 /// Error variants which can be encountered when creating a new [`Group`] from
 /// unparsed input.

crates/k8s-version/src/group.rs

@@ -4,19 +4,18 @@ use std::{
     num::ParseIntError,
     ops::{Add, AddAssign, Sub, SubAssign},
     str::FromStr,
+    sync::LazyLock,
 };
 
-use lazy_static::lazy_static;
 use regex::Regex;
 use snafu::{OptionExt, ResultExt, Snafu};
 
 #[cfg(feature = "darling")]
 use darling::FromMeta;
 
-lazy_static! {
-    static ref LEVEL_REGEX: Regex = Regex::new(r"^(?P<identifier>[a-z]+)(?P<version>\d+)$")
-        .expect("failed to compile level regex");
-}
+static LEVEL_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new(r"^(?P<identifier>[a-z]+)(?P<version>\d+)$").expect("failed to compile level regex")
+});
 
 /// Error variants which can be encountered when creating a new [`Level`] from
 /// unparsed input.

crates/k8s-version/src/level.rs

@@ -1,6 +1,5 @@
-use std::{cmp::Ordering, fmt::Display, num::ParseIntError, str::FromStr};
+use std::{cmp::Ordering, fmt::Display, num::ParseIntError, str::FromStr, sync::LazyLock};
 
-use lazy_static::lazy_static;
 use regex::Regex;
 use snafu::{OptionExt, ResultExt, Snafu};
 
@@ -9,11 +8,10 @@ use darling::FromMeta;
 
 use crate::{Level, ParseLevelError};
 
-lazy_static! {
-    static ref VERSION_REGEX: Regex =
-        Regex::new(r"^v(?P<major>\d+)(?P<level>[a-z0-9][a-z0-9-]{0,60}[a-z0-9])?$")
-            .expect("failed to compile version regex");
-}
+static VERSION_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new(r"^v(?P<major>\d+)(?P<level>[a-z0-9][a-z0-9-]{0,60}[a-z0-9])?$")
+        .expect("failed to compile version regex")
+});
 
 /// Error variants which can be encountered when creating a new [`Version`] from
 /// unparsed input.

crates/k8s-version/src/version.rs

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Changed
+
+- Replace `lazy_static` with `std::cell::LazyCell` ([#xxx]).
+
+[#xxx](https://github.com/stackabletech/operator-rs/pull/xxx)
+
 ## [0.70.0] - 2024-07-10
 
 ### Added

crates/stackable-operator/CHANGELOG.md

@@ -24,7 +24,6 @@ futures.workspace = true
 json-patch.workspace = true
 k8s-openapi.workspace = true
 kube.workspace = true
-lazy_static.workspace = true
 opentelemetry_sdk.workspace = true
 opentelemetry-jaeger.workspace = true
 product-config.workspace = true

crates/stackable-operator/Cargo.toml

@@ -43,15 +43,23 @@
 //! assert_eq!(opa_config.document_url(&cluster, Some("allow"), OpaApiVersion::V1), "v1/data/test/allow".to_string());
 //! assert_eq!(opa_config.full_document_url(&cluster, "http://localhost:8081", None, OpaApiVersion::V1), "http://localhost:8081/v1/data/test".to_string());
 //! ```
+use std::sync::LazyLock;
+
 use crate::client::{Client, GetApi};
 use k8s_openapi::{api::core::v1::ConfigMap, NamespaceResourceScope};
 use kube::{Resource, ResourceExt};
-use lazy_static::lazy_static;
 use regex::Regex;
 use schemars::{self, JsonSchema};
 use serde::{Deserialize, Serialize};
 use snafu::{OptionExt, ResultExt, Snafu};
 
+static DOT_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new("\\.").expect("failed to compile OPA dot regex"));
+
+/// To remove leading slashes from OPA package name (if present)
+static LEADING_SLASH_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new("(/*)(.*)").expect("failed to compile OPA leasing slash regex"));
+
 type Result<T, E = Error> = std::result::Result<T, E>;
 
 #[derive(Debug, Snafu)]
@@ -72,11 +80,6 @@ pub enum Error {
     },
 }
 
-lazy_static! {
-    static ref DOT_REGEX: Regex = Regex::new("\\.").unwrap();
-    /// To remove leading slashes from OPA package name (if present)
-    static ref LEADING_SLASH_REGEX: Regex = Regex::new("(/*)(.*)").unwrap();
-}
 /// Indicates the OPA API version. This is required to choose the correct
 /// path when constructing the OPA urls to query.
 pub enum OpaApiVersion {