fix: only append dot if default clusterdomain is used

Author: dervoeti

crates/stackable-operator/src/utils/cluster_info.rs

@@ -24,12 +24,9 @@ impl KubernetesClusterInfo {
     pub fn new(cluster_info_opts: &KubernetesClusterInfoOpts) -> Self {
         let cluster_domain = match &cluster_info_opts.kubernetes_cluster_domain {
             Some(cluster_domain) => {
-                // Append trailing dot to make the domain name a FQDN to improve DNS lookup performance, see https://github.com/stackabletech/issues/issues/656
-                let cluster_domain = DomainName::from_str(&format!("{}.", cluster_domain))
-                    .expect("cluster_domain should already have been validated");
                 tracing::info!(%cluster_domain, "Using configured Kubernetes cluster domain");
 
-                cluster_domain
+                cluster_domain.clone()
             }
             None => {
                 // TODO(sbernauer): Do some sort of advanced auto-detection, see https://github.com/stackabletech/issues/issues/436.
@@ -55,7 +52,8 @@ mod test {
 
     #[rstest]
     #[case(None, KUBERNETES_CLUSTER_DOMAIN_DEFAULT)]
-    #[case(Some("example.com".parse().unwrap()), "example.com.")]
+    #[case(Some("example.com".parse().unwrap()), "example.com")]
+    #[case(Some("example.com.".parse().unwrap()), "example.com.")]
     fn test_kubernetes_cluster_info_creation(
         #[case] kubernetes_cluster_domain: Option<DomainName>,
         #[case] expected_cluster_domain: &str,