Skip to content

Commit b0fa449

Browse files
sbernauerTechassi
andauthored
Apply suggestions from code review
Co-authored-by: Techassi <[email protected]>
1 parent 4dbb29d commit b0fa449

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

crates/stackable-operator/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ All notable changes to this project will be documented in this file.
1010

1111
### Changed
1212

13-
- BREAKING: Made `DEFAULT_OIDC_WELLKNOWN_PATH` private. Use `AuthenticationProvider::well_known_url` instead ([#910]).
13+
- BREAKING: Made `DEFAULT_OIDC_WELLKNOWN_PATH` private. Use `AuthenticationProvider::well_known_config_url` instead ([#910]).
1414

1515
[#910]: https://github.com/stackabletech/operator-rs/pull/910
1616

crates/stackable-operator/src/commons/authentication/oidc.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,9 @@ impl AuthenticationProvider {
119119
}
120120
}
121121

122-
/// Base [`Url`] without any path set (so only protocol, host, port and such).
122+
/// Returns the base [`Url`] without any path segments.
123+
///
124+
/// The base url only contains the scheme, the host, and an optional port.
123125
fn base_url(&self) -> Result<Url> {
124126
let mut url = Url::parse(&format!(
125127
"http://{host}:{port}",
@@ -143,7 +145,7 @@ impl AuthenticationProvider {
143145

144146
/// Returns the OIDC endpoint [`Url`] without a trailing slash.
145147
///
146-
/// To get the well-known URL, please use [`Self::well_known_url`].
148+
/// To retrieve the well-known OIDC configuration url, please use [`Self::well_known_config_url`].
147149
pub fn endpoint_url(&self) -> Result<Url> {
148150
let mut url = self.base_url()?;
149151
// Some tools can not cope with a trailing slash, so let's remove that

0 commit comments

Comments
 (0)