Skip to content

Commit cf859db

Browse files
committed
test: Improve tests
1 parent c57e8c0 commit cf859db

File tree

5 files changed

+128
-8
lines changed

5 files changed

+128
-8
lines changed

crates/stackable-versioned/fixtures/inputs/pass/persons_to_v1alpha1.json

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,44 @@
1616
"spec": {
1717
"username": "sbernauer"
1818
}
19+
},
20+
{
21+
"apiVersion": "v1alpha2",
22+
"kind": "Person",
23+
"spec": {
24+
"username": "sbernauer",
25+
"firstName": "Sebastian",
26+
"lastName": "Bernauer"
27+
}
28+
},
29+
{
30+
"apiVersion": "v1beta1",
31+
"kind": "Person",
32+
"spec": {
33+
"username": "sbernauer",
34+
"firstName": "Sebastian",
35+
"lastName": "Bernauer"
36+
}
37+
},
38+
{
39+
"apiVersion": "v2",
40+
"kind": "Person",
41+
"spec": {
42+
"username": "sbernauer",
43+
"firstName": "Sebastian",
44+
"lastName": "Bernauer",
45+
"gender": "Male"
46+
}
47+
},
48+
{
49+
"apiVersion": "v3",
50+
"kind": "Person",
51+
"spec": {
52+
"username": "sbernauer",
53+
"firstName": "Sebastian",
54+
"lastName": "Bernauer",
55+
"gender": "Male"
56+
}
1957
}
2058
]
2159
}

crates/stackable-versioned/fixtures/inputs/pass/persons_to_v3.json

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,44 @@
1616
"spec": {
1717
"username": "sbernauer"
1818
}
19+
},
20+
{
21+
"apiVersion": "v1alpha2",
22+
"kind": "Person",
23+
"spec": {
24+
"username": "sbernauer",
25+
"firstName": "Sebastian",
26+
"lastName": "Bernauer"
27+
}
28+
},
29+
{
30+
"apiVersion": "v1beta1",
31+
"kind": "Person",
32+
"spec": {
33+
"username": "sbernauer",
34+
"firstName": "Sebastian",
35+
"lastName": "Bernauer"
36+
}
37+
},
38+
{
39+
"apiVersion": "v2",
40+
"kind": "Person",
41+
"spec": {
42+
"username": "sbernauer",
43+
"firstName": "Sebastian",
44+
"lastName": "Bernauer",
45+
"gender": "Male"
46+
}
47+
},
48+
{
49+
"apiVersion": "v3",
50+
"kind": "Person",
51+
"spec": {
52+
"username": "sbernauer",
53+
"firstName": "Sebastian",
54+
"lastName": "Bernauer",
55+
"gender": "Male"
56+
}
1957
}
2058
]
2159
}

crates/stackable-versioned/src/flux_converter/tests/mod.rs

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,16 @@ mod tests {
133133
glob!("../../../fixtures/inputs/pass/", "*.json", |path| {
134134
let (review, response) = run_for_file(path);
135135

136-
assert_eq!(response.result.status, Some(StatusSummary::Success));
137-
assert_eq!(review.request.unwrap().uid, response.uid);
138-
139136
let formatted = serde_json::to_string_pretty(&response)
140137
.expect("Failed to serialize ConversionResponse");
141138
assert_snapshot!(formatted);
139+
140+
assert_eq!(
141+
response.result.status,
142+
Some(StatusSummary::Success),
143+
"File {path:?} should be converted successfully"
144+
);
145+
assert_eq!(review.request.unwrap().uid, response.uid);
142146
})
143147
}
144148

@@ -147,14 +151,18 @@ mod tests {
147151
glob!("../../../fixtures/inputs/fail/", "*.json", |path| {
148152
let (review, response) = run_for_file(path);
149153

150-
assert_eq!(response.result.status, Some(StatusSummary::Failure));
151-
if let Some(request) = &review.request {
152-
assert_eq!(request.uid, response.uid);
153-
}
154-
155154
let formatted = serde_json::to_string_pretty(&response)
156155
.expect("Failed to serialize ConversionResponse");
157156
assert_snapshot!(formatted);
157+
158+
assert_eq!(
159+
response.result.status,
160+
Some(StatusSummary::Failure),
161+
"File {path:?} should *not* be converted successfully"
162+
);
163+
if let Some(request) = &review.request {
164+
assert_eq!(request.uid, response.uid);
165+
}
158166
})
159167
}
160168

crates/stackable-versioned/src/flux_converter/tests/snapshots/stackable_versioned__flux_converter__tests__tests__pass@persons_to_v1alpha1.json.snap

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/stackable-versioned/src/flux_converter/tests/snapshots/stackable_versioned__flux_converter__tests__tests__pass@persons_to_v3.json.snap

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)