chore: Apply suggestions

Co-authored-by: Sebastian Bernauer <[email protected]>

Author: Techassi

crates/stackable-operator/CHANGELOG.md

@@ -8,7 +8,7 @@ All notable changes to this project will be documented in this file.
 
 - Add `CustomResourceDefinitionMaintainer` which applies and patches CRDs triggered by TLS
   certificate rotations of the `ConversionWebhookServer`. It additionally provides a `oneshot`
-  channel which can be used to trigger creation/patching of any default custom resources deployed by
+  channel which can for example be used to trigger creation/patching of any custom resources deployed by
   the operator ([#1099]).
 - Add a `Client::create_if_missing` associated function to create a resource if it doesn't
   exist ([#1099]).

crates/stackable-operator/src/crd/maintainer.rs

@@ -220,10 +220,10 @@ impl CustomResourceDefinitionMaintainer {
             // After the reconciliation of the CRDs, the initial reconcile heartbeat is sent out
             // via the oneshot channel.
             if let Some(initial_reconcile_tx) = initial_reconcile_tx.take() {
-                match initial_reconcile_tx.send(()) {
-                    Ok(_) => {}
-                    Err(_) => return SendInitialReconcileHeartbeatSnafu.fail(),
-                }
+                ensure!(
+                    initial_reconcile_tx.send(()).is_ok(),
+                    SendInitialReconcileHeartbeatSnafu
+                );
             }
         }
 

crates/stackable-webhook/src/lib.rs

@@ -97,6 +97,10 @@ impl WebhookServer {
     pub const DEFAULT_HTTPS_PORT: u16 = 8443;
     /// The default IP address [`Ipv4Addr::UNSPECIFIED`] (`0.0.0.0`) the webhook server binds to,
     /// which represents binding on all network addresses.
+    //
+    // TODO: We might want to switch to `Ipv6Addr::UNSPECIFIED)` here, as this *normally* binds to IPv4
+    // and IPv6. However, it's complicated and depends on the underlying system...
+    // If we do so, we should set `set_only_v6(false)` on the socket to not rely on system defaults.
     pub const DEFAULT_LISTEN_ADDRESS: IpAddr = IpAddr::V4(Ipv4Addr::UNSPECIFIED);
     /// The default socket address `0.0.0.0:8443` the webhook server binds to.
     pub const DEFAULT_SOCKET_ADDRESS: SocketAddr =