refactor(stackable-telemetry): Prefix builder methods with with_.

I avoided prefixing `enabled()` because it sounds strange.

Author: NickLarsenNZ

crates/stackable-telemetry/src/tracing/mod.rs

@@ -447,15 +447,15 @@ mod test {
             .service_name("test")
             .with_console_output(
                 Settings::builder()
-                    .environment_variable("ABC_A")
-                    .default_level(LevelFilter::TRACE)
+                    .with_environment_variable("ABC_A")
+                    .with_default_level(LevelFilter::TRACE)
                     .enabled(true)
                     .build(),
             )
             .with_console_output(
                 Settings::builder()
-                    .environment_variable("ABC_B")
-                    .default_level(LevelFilter::DEBUG)
+                    .with_environment_variable("ABC_B")
+                    .with_default_level(LevelFilter::DEBUG)
                     .enabled(true)
                     .build(),
             )
@@ -482,8 +482,8 @@ mod test {
             .service_name("test")
             .with_console_output(
                 Settings::builder()
-                    .environment_variable("ABC_CONSOLE")
-                    .default_level(LevelFilter::INFO)
+                    .with_environment_variable("ABC_CONSOLE")
+                    .with_default_level(LevelFilter::INFO)
                     .enabled(true)
                     .build(),
             )

crates/stackable-telemetry/src/tracing/settings/console_log.rs

@@ -22,7 +22,7 @@ pub struct ConsoleLogSettingsBuilder {
 }
 
 impl ConsoleLogSettingsBuilder {
-    pub fn log_format(mut self, format: Format) -> Self {
+    pub fn with_log_format(mut self, format: Format) -> Self {
         self.log_format = format;
         self
     }
@@ -108,11 +108,11 @@ mod test {
             log_format: Format::Plain,
         };
         let result = Settings::builder()
-            .environment_variable("hello")
-            .default_level(LevelFilter::DEBUG)
+            .with_environment_variable("hello")
+            .with_default_level(LevelFilter::DEBUG)
             .enabled(true)
             .console_log_settings_builder()
-            .log_format(Format::Plain)
+            .with_log_format(Format::Plain)
             // color
             .build();
 

crates/stackable-telemetry/src/tracing/settings/mod.rs

@@ -54,16 +54,22 @@ impl Build<Settings> for SettingsBuilder {
 }
 
 impl SettingsBuilder {
-    pub fn environment_variable(mut self, name: &'static str) -> Self {
+    pub fn with_environment_variable(mut self, name: &'static str) -> Self {
         self.environment_variable = name;
         self
     }
 
-    pub fn default_level(mut self, level: impl Into<LevelFilter>) -> Self {
+    pub fn with_default_level(mut self, level: impl Into<LevelFilter>) -> Self {
         self.default_level = level.into();
         self
     }
 
+    // TODO (@NickLarsenNZ): Currently this has to be called to enable the
+    // subscriber. Eventually it should become optional, and default to on (if
+    // settings are supplied). Therefore, the fields in TracingBuilder to hold
+    // the subscriber settings should become Option<T> so that the subscriber is
+    // disabled when not configured, is enabled when configured, while still
+    // controllable through this function. Then this can be renamed to `with_enabled`
     pub fn enabled(mut self, enabled: bool) -> Self {
         self.enabled = enabled;
         self
@@ -139,8 +145,8 @@ mod test {
             enabled: true,
         };
         let result = Settings::builder()
-            .environment_variable("hello")
-            .default_level(LevelFilter::DEBUG)
+            .with_environment_variable("hello")
+            .with_default_level(LevelFilter::DEBUG)
             .enabled(true)
             .build();
 

crates/stackable-telemetry/src/tracing/settings/otlp_log.rs

@@ -90,8 +90,8 @@ mod test {
             },
         };
         let result = Settings::builder()
-            .environment_variable("hello")
-            .default_level(LevelFilter::DEBUG)
+            .with_environment_variable("hello")
+            .with_default_level(LevelFilter::DEBUG)
             .enabled(true)
             .otlp_log_settings_builder()
             .build();

crates/stackable-telemetry/src/tracing/settings/otlp_trace.rs

@@ -90,8 +90,8 @@ mod test {
             },
         };
         let result = Settings::builder()
-            .environment_variable("hello")
-            .default_level(LevelFilter::DEBUG)
+            .with_environment_variable("hello")
+            .with_default_level(LevelFilter::DEBUG)
             .enabled(true)
             .otlp_trace_settings_builder()
             .build();