chore!: Rename KubernetesServiceType back to ServiceType (#791)

* chore!: Rename KubernetesServiceType back to ServiceType

* changelog

Author: sbernauer

crates/stackable-operator/CHANGELOG.md

@@ -4,11 +4,11 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
-- Support specifying externalTrafficPolicy in Services created by listener-operator ([#773], [#789]).
-- BREAKING: Rename `commons::listener::ServiceType` to `commons::listener::KubernetesServiceType` ([#773]).
+- Support specifying externalTrafficPolicy in Services created by listener-operator ([#773], [#789], [#791]).
 
 [#773]: https://github.com/stackabletech/operator-rs/pull/773
 [#789]: https://github.com/stackabletech/operator-rs/pull/789
+[#791]: https://github.com/stackabletech/operator-rs/pull/791
 
 ## [0.67.1] - 2024-05-08
 

crates/stackable-operator/src/commons/listener.rs

@@ -50,7 +50,7 @@ use crate::builder::pod::volume::ListenerOperatorVolumeSourceBuilder;
 )]
 #[serde(rename_all = "camelCase")]
 pub struct ListenerClassSpec {
-    pub service_type: KubernetesServiceType,
+    pub service_type: ServiceType,
 
     /// Annotations that should be added to the Service object.
     #[serde(default)]
@@ -73,10 +73,11 @@ impl ListenerClassSpec {
 
 /// The method used to access the services.
 //
-// Please note that this represents a Kubernetes type, so the name of the enum variant needs to exactly match the
-// Kubernetes service type.
-#[derive(Serialize, Deserialize, Clone, Copy, Debug, JsonSchema, PartialEq, Eq, strum::Display)]
-pub enum KubernetesServiceType {
+// Please note that this does not necessarely need to be restricted to the same Service types Kubernetes supports.
+// Listeners currently happens to support the same set of service types as upstream Kubernetes, but we still want to
+// have the freedom to add custom ones in the future (for example: Istio ingress?).
+#[derive(Serialize, Deserialize, Clone, Copy, Debug, JsonSchema, PartialEq, Eq)]
+pub enum ServiceType {
     /// Reserve a port on each node.
     NodePort,