Skip to content

Commit e421241

Browse files
authored
Merge branch 'main' into issues/1005
2 parents 68dfb65 + 61c8a4f commit e421241

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

crates/stackable-operator/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
77
### Changed
88

99
- Update `kube` to `1.1.0` ([#1049]).
10+
- BREAKING: Return type for `ListenerOperatorVolumeSourceBuilder::new()` is no onger a `Result` ([#1058]).
1011

1112
### Removed
1213

@@ -15,6 +16,7 @@ All notable changes to this project will be documented in this file.
1516

1617
[#1049]: https://github.com/stackabletech/operator-rs/pull/1049
1718
[#1054]: https://github.com/stackabletech/operator-rs/pull/1054
19+
[#1058]: https://github.com/stackabletech/operator-rs/pull/1058
1820
[#1060]: https://github.com/stackabletech/operator-rs/pull/1060
1921

2022
## [0.93.2] - 2025-05-26

crates/stackable-operator/src/builder/pod/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,6 @@ impl PodBuilder {
396396
) -> Result<&mut Self> {
397397
let listener_reference = ListenerReference::ListenerClass(listener_class.to_string());
398398
let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
399-
.context(ListenerVolumeSnafu { name: volume_name })?
400399
.build_ephemeral()
401400
.context(ListenerVolumeSnafu { name: volume_name })?;
402401

@@ -483,7 +482,6 @@ impl PodBuilder {
483482
) -> Result<&mut Self> {
484483
let listener_reference = ListenerReference::ListenerName(listener_name.to_string());
485484
let volume = ListenerOperatorVolumeSourceBuilder::new(&listener_reference, labels)
486-
.context(ListenerVolumeSnafu { name: volume_name })?
487485
.build_ephemeral()
488486
.context(ListenerVolumeSnafu { name: volume_name })?;
489487

crates/stackable-operator/src/builder/pod/volume.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,6 @@ pub enum ListenerOperatorVolumeSourceBuilderError {
471471
/// &ListenerReference::ListenerClass("nodeport".into()),
472472
/// &labels,
473473
/// )
474-
/// .unwrap()
475474
/// .build_ephemeral()
476475
/// .unwrap();
477476
///
@@ -497,11 +496,11 @@ impl ListenerOperatorVolumeSourceBuilder {
497496
pub fn new(
498497
listener_reference: &ListenerReference,
499498
labels: &Labels,
500-
) -> Result<ListenerOperatorVolumeSourceBuilder, ListenerOperatorVolumeSourceBuilderError> {
501-
Ok(Self {
499+
) -> ListenerOperatorVolumeSourceBuilder {
500+
Self {
502501
listener_reference: listener_reference.to_owned(),
503502
labels: labels.to_owned(),
504-
})
503+
}
505504
}
506505

507506
fn build_spec(&self) -> PersistentVolumeClaimSpec {
@@ -636,8 +635,7 @@ mod tests {
636635
let builder = ListenerOperatorVolumeSourceBuilder::new(
637636
&ListenerReference::ListenerClass("public".into()),
638637
&labels,
639-
)
640-
.unwrap();
638+
);
641639

642640
let volume_source = builder.build_ephemeral().unwrap();
643641

0 commit comments

Comments
 (0)