test: Add roundtrip generation via macro

sbernauer · sbernauer · commit eb141e0ea1fa · 2025-05-28T17:07:22.000+02:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -25,7 +25,8 @@ educe =  { version = "0.6.0", default-features = false, features = ["Clone", "De
 either = "1.13.0"
 futures = "0.3.30"
 futures-util = "0.3.30"
-indexmap = "2.5"
+indexmap = "2.5.0"
+indoc = "2.0.6"
 insta = { version= "1.40", features = ["glob"] }
 hyper = { version = "1.4.1", features = ["full"] }
 hyper-util = "0.1.8"
diff --git a/crates/stackable-operator/Cargo.toml b/crates/stackable-operator/Cargo.toml
@@ -28,6 +28,7 @@ dockerfile-parser.workspace = true
 either.workspace = true
 educe.workspace = true
 futures.workspace = true
+indoc.workspace = true
 indexmap.workspace = true
 json-patch.workspace = true
 k8s-openapi.workspace = true
diff --git a/crates/stackable-operator/src/crd/authentication/core/mod.rs b/crates/stackable-operator/src/crd/authentication/core/mod.rs
@@ -153,3 +153,61 @@ pub mod versioned {
         oidc: Option<oidc::v1alpha1::ClientAuthenticationOptions<O>>,
     }
 }
+
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData
+    for v1alpha1::AuthenticationClassSpec
+{
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+          - provider:
+              static:
+                userCredentialsSecret:
+                  name: simple-users-credentials
+          - provider:
+              ldap:
+                hostname: my.ldap.server
+                port: 389
+                searchBase: ou=users,dc=example,dc=org
+                searchFilter: foo
+                bindCredentials:
+                  secretClass: openldap-bind-credentials
+                ldapFieldNames:
+                  email: email
+                  givenName: givenName
+                  group: group
+                  surname: surname
+                  uid: uid
+                tls:
+                  verification:
+                    server:
+                      caCert:
+                        secretClass: s3-cert
+          - provider:
+              oidc:
+                hostname: my.keycloak.server
+                port: 8080
+                rootPath: /realms/master
+                scopes:
+                  - email
+                  - openid
+                  - profile
+                principalClaim: preferred_username
+                providerHint: Keycloak
+                tls:
+                  verification:
+                    server:
+                      caCert:
+                        secretClass: s3-cert
+          - provider:
+              tls: {}
+          - provider:
+              tls:
+                clientCertSecretClass: client-auth-tls
+          - provider:
+              kerberos:
+                kerberosSecretClass: kerberos-auth
+        "})
+        .expect("Failed to parse AuthenticationClassSpec YAML")
+    }
+}
diff --git a/crates/stackable-operator/src/crd/authentication/ldap/v1alpha1_impl.rs b/crates/stackable-operator/src/crd/authentication/ldap/v1alpha1_impl.rs
@@ -169,7 +169,7 @@ impl Default for FieldNames {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::commons::secret_class::SecretClassVolume;
+    use crate::{commons::secret_class::SecretClassVolume, utils::yaml_from_str_singleton_map};
 
     #[test]
     fn minimal() {
@@ -213,9 +213,7 @@ mod tests {
                   caCert:
                     secretClass: ldap-ca-cert
         "#;
-        let deserializer = serde_yaml::Deserializer::from_str(input);
-        let ldap: AuthenticationProvider =
-            serde_yaml::with::singleton_map_recursive::deserialize(deserializer).unwrap();
+        let ldap: AuthenticationProvider = yaml_from_str_singleton_map(input).unwrap();
 
         assert_eq!(ldap.port(), 42);
         assert!(ldap.tls.uses_tls());
diff --git a/crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs b/crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs
@@ -365,7 +365,7 @@ mod tests {
     use super::*;
     use crate::{
         config::fragment::validate, product_config_utils::env_vars_from,
-        product_logging::spec::default_container_log_config,
+        product_logging::spec::default_container_log_config, utils::yaml_from_str_singleton_map,
     };
 
     #[test]
@@ -435,9 +435,7 @@ mod tests {
               --git-config: key:value,safe.directory:/safe-dir
           "#;
 
-        let deserializer = serde_yaml::Deserializer::from_str(git_sync_spec);
-        let git_syncs: Vec<GitSync> =
-            serde_yaml::with::singleton_map_recursive::deserialize(deserializer).unwrap();
+        let git_syncs: Vec<GitSync> = yaml_from_str_singleton_map(git_sync_spec).unwrap();
 
         let resolved_product_image = ResolvedProductImage {
             image: "oci.stackable.tech/sdp/product:latest".to_string(),
diff --git a/crates/stackable-operator/src/crd/listener/class/mod.rs b/crates/stackable-operator/src/crd/listener/class/mod.rs
@@ -68,3 +68,24 @@ pub mod versioned {
         pub preferred_address_type: core_v1alpha1::PreferredAddressType,
     }
 }
+
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData
+    for v1alpha1::ListenerClassSpec
+{
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+          - serviceType: ClusterIP
+          - serviceType: NodePort
+          - serviceType: LoadBalancer
+          - serviceType: ClusterIP
+            loadBalancerAllocateNodePorts: false
+            loadBalancerClass: foo
+            serviceAnnotations:
+              foo: bar
+            serviceExternalTrafficPolicy: Local
+            preferredAddressType: HostnameConservative
+        "})
+        .expect("Failed to parse ListenerClassSpec YAML")
+    }
+}
diff --git a/crates/stackable-operator/src/crd/listener/listeners/mod.rs b/crates/stackable-operator/src/crd/listener/listeners/mod.rs
@@ -163,3 +163,56 @@ pub mod versioned {
         Cluster,
     }
 }
+
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData for v1alpha1::ListenerSpec {
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+          - {}
+          - className: cluster-internal
+            extraPodLabelSelectorLabels: {}
+            ports: []
+            publishNotReadyAddresses: true
+          - className: external-unstable
+            extraPodLabelSelectorLabels:
+              foo: bar
+            ports:
+              - name: http
+                port: 8080
+                protocol: TCP
+            publishNotReadyAddresses: true
+        "})
+        .expect("Failed to parse ListenerSpec YAML")
+    }
+}
+
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData
+    for v1alpha1::PodListenersSpec
+{
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+          - listeners: {}
+          - listeners:
+              foo:
+                scope: Node
+          - listeners:
+              foo:
+                scope: Cluster
+                ingressAddresses:
+                  - address: 1.2.3.4
+                    addressType: IP
+                    ports: {}
+          - listeners:
+              foo:
+                scope: Cluster
+                ingressAddresses:
+                  - address: foo.bar
+                    addressType: Hostname
+                    ports:
+                      http: 8080
+                      https: 8443
+        "})
+        .expect("Failed to parse PodListenersSpec YAML")
+    }
+}
diff --git a/crates/stackable-operator/src/crd/s3/bucket/mod.rs b/crates/stackable-operator/src/crd/s3/bucket/mod.rs
@@ -49,3 +49,34 @@ pub mod versioned {
         pub connection: conn_v1alpha1::ConnectionSpec,
     }
 }
+
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData for v1alpha1::BucketSpec {
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+          - bucketName: my-example-bucket
+            connection:
+              reference: my-connection-resource
+          - bucketName: foo
+            connection:
+              inline:
+                host: s3.example.com
+          - bucketName: foo
+            connection:
+              inline:
+                host: s3.example.com
+                port: 1234
+                accessStyle: VirtualHosted
+                credentials:
+                  secretClass: s3-credentials
+                region:
+                  name: eu-west-1
+                tls:
+                  verification:
+                    server:
+                      caCert:
+                        secretClass: s3-cert
+        "})
+        .expect("Failed to parse BucketSpec YAML")
+    }
+}
diff --git a/crates/stackable-operator/src/crd/s3/connection/mod.rs b/crates/stackable-operator/src/crd/s3/connection/mod.rs
@@ -101,6 +101,38 @@ pub mod versioned {
     }
 }
 
+#[cfg(test)]
+impl stackable_versioned::flux_converter::test_utils::RoundtripTestData
+    for v1alpha1::ConnectionSpec
+{
+    fn get_roundtrip_test_data() -> Vec<Self> {
+        crate::utils::yaml_from_str_singleton_map(indoc::indoc! {"
+            - host: s3.example.com
+            - host: s3.example.com
+              port: 1234
+              accessStyle: VirtualHosted
+              credentials:
+                secretClass: s3-credentials
+              region:
+                name: eu-west-1
+              tls: null
+            - host: s3.example.com
+              region:
+                name: us-east-1
+              tls:
+                verification:
+                  none: {}
+            - host: s3.example.com
+              tls:
+                verification:
+                  server:
+                    caCert:
+                      secretClass: s3-cert
+        "})
+        .expect("Failed to parse ConnectionSpec YAML")
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use std::collections::BTreeMap;
diff --git a/crates/stackable-operator/src/utils/mod.rs b/crates/stackable-operator/src/utils/mod.rs
@@ -25,3 +25,11 @@ pub use self::{option::OptionExt, url::UrlExt};
 pub(crate) fn format_full_controller_name(operator: &str, controller: &str) -> String {
     format!("{operator}_{controller}")
 }
+
+pub fn yaml_from_str_singleton_map<'a, D>(input: &'a str) -> Result<D, serde_yaml::Error>
+where
+    D: serde::Deserialize<'a>,
+{
+    let deserializer = serde_yaml::Deserializer::from_str(input);
+    serde_yaml::with::singleton_map_recursive::deserialize(deserializer)
+}
diff --git a/crates/stackable-versioned-macros/src/codegen/container/mod.rs b/crates/stackable-versioned-macros/src/codegen/container/mod.rs
@@ -5,6 +5,7 @@ use proc_macro2::{Span, TokenStream};
 use quote::{ToTokens, quote};
 use syn::{Attribute, Ident, ItemEnum, ItemStruct, Path, Visibility, parse_quote};
 
+use super::flux_converter::{generate_kubernetes_conversion, generate_kubernetes_conversion_tests};
 use crate::{
     attrs::{
         container::StandaloneContainerAttributes,
@@ -140,13 +141,19 @@ impl Container {
             is_nested,
         ));
         // TODO: Do we need a kubernetes_options.skip_conversion as well?
-        tokens.extend(super::flux_converter::generate_kubernetes_conversion(
+        tokens.extend(generate_kubernetes_conversion(
             &s.common.idents.kubernetes,
             &s.common.idents.original,
             enum_variant_idents,
             enum_variant_strings,
             kubernetes_options,
         ));
+        tokens.extend(generate_kubernetes_conversion_tests(
+            &s.common.idents.kubernetes,
+            &s.common.idents.original,
+            enum_variant_strings,
+            kubernetes_options,
+        ));
 
         Some(tokens)
     }
diff --git a/crates/stackable-versioned-macros/src/codegen/flux_converter.rs b/crates/stackable-versioned-macros/src/codegen/flux_converter.rs
diff --git a/crates/stackable-versioned/src/flux_converter/mod.rs b/crates/stackable-versioned/src/flux_converter/mod.rs
diff --git a/crates/stackable-versioned/src/flux_converter/tests/mod.rs b/crates/stackable-versioned/src/flux_converter/tests/mod.rs
diff --git a/crates/stackable-versioned/src/lib.rs b/crates/stackable-versioned/src/lib.rs
