Skip to content

Commit f27dec5

Browse files
committed
review feedback
1 parent e421241 commit f27dec5

File tree

1 file changed

+5
-1
lines changed
  • crates/stackable-operator/src/commons

1 file changed

+5
-1
lines changed

crates/stackable-operator/src/commons/rbac.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,14 @@ pub enum Error {
2828
}
2929

3030
/// Build RBAC objects for the product workloads.
31-
/// The names of the service account and role binding match the following templates:
31+
/// The names of the service account and role binding match the following patterns:
3232
/// - `{resource_name}-serviceaccount`
3333
/// - `{resource_name}-rolebinding`
3434
///
35+
/// A previous version of this function used the `product_name` instead of the `resource_name`,
36+
/// but this caused conflicts when deploying multiple instances of a product in the same namespace.
37+
/// See <https://stackable.atlassian.net/browse/SUP-148> for more details.
38+
///
3539
/// The service account is bound to a cluster role named `{product_name}-clusterrole` which
3640
/// must already exist.
3741
pub fn build_rbac_resources<T: Clone + Resource<DynamicType = ()>>(

0 commit comments

Comments
 (0)