From f37a82acba69056f16aa9ac1faf17fabd9150457 Mon Sep 17 00:00:00 2001 From: Techassi Date: Thu, 22 Aug 2024 16:16:50 +0200 Subject: [PATCH] refactor: Adjust variant rename validation error span --- .../src/attrs/variant.rs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/crates/stackable-versioned-macros/src/attrs/variant.rs b/crates/stackable-versioned-macros/src/attrs/variant.rs index cb831e52b..4ddc1f446 100644 --- a/crates/stackable-versioned-macros/src/attrs/variant.rs +++ b/crates/stackable-versioned-macros/src/attrs/variant.rs @@ -46,14 +46,13 @@ impl VariantAttributes { errors.handle(self.common.validate(&self.ident, &ItemType::Variant)); // Validate names of renames - if !self - .common - .renames - .iter() - .all(|r| r.from.is_case(Case::Pascal)) - { - errors - .push(Error::custom("renamed variants must use PascalCase").with_span(&self.ident)); + for rename in &self.common.renames { + if !rename.from.is_case(Case::Pascal) { + errors.push( + Error::custom("renamed variant must use PascalCase") + .with_span(&rename.from.span()), + ) + } } errors.finish()?;