Satisfy pre-commit

Author: nightkr

.github/workflows/generate_prs.yml

@@ -97,8 +97,12 @@ jobs:
           GH_ACCESS_TOKEN: ${{ secrets.gh_access_token }}
           REPOSITORY: ${{ matrix.repository }}
           # tags local excludes all actions that actually generate PRs
-          DRY_RUN_FLAGS: ${{ inputs.dry-run && '--tags local' || '' }}
+          DRY_RUN_FLAGS: ${{ inputs.dry-run && '--tags=local' || '' }}
+        # shellsheck disable=SC2086
         run: |
-          # Funnel via JSON to ensure that values are escaped properly
           echo '{}' | jq '{commit_hash: $ENV.GITHUB_SHA, author: $ENV.AUTHOR, reason: $ENV.REASON, custom_pr_title: $ENV.CUSTOM_PR_TITLE, base_dir: $pwd, gh_access_token: $ENV.GH_ACCESS_TOKEN, shard_repositories: [$ENV.REPOSITORY]} | with_entries(select(.value != null and .value != ""))' --arg pwd "$(pwd)" > vars.json
+          # $DRY_RUN_FLAGS is intentionally not quoted, since we need to avoid
+          # passing an argument if we're not in dry mode.
+          # This is safe, since it always has one of two hard-coded values.
+          # shellcheck disable=SC2086
           ansible-playbook playbook/playbook.yaml --extra-vars "@vars.json" $DRY_RUN_FLAGS

test.sh

@@ -2,4 +2,4 @@
 
 rm -fr work || true
 mkdir -p work
-ansible-playbook playbook/playbook.yaml --tags "local" --extra-vars "gh_access_token=unneeded base_dir=$(pwd) commit_hash=12345 reason='original message'" "$@"
+ansible-playbook playbook/playbook.yaml --tags="local" --extra-vars "gh_access_token=unneeded base_dir=$(pwd) commit_hash=12345 reason='original message'" "$@"