Skip to content

Commit ee48a9a

Browse files
adwk67NickLarsenNZ
andauthored
Apply suggestions from code review
Co-authored-by: Nick <[email protected]>
1 parent d7a89c2 commit ee48a9a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

template/.github/workflows/build.yml.j2

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,9 @@ jobs:
347347
bin: cargo-set-version
348348
- name: Update version if PR against main branch
349349
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
350-
run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
350+
env:
351+
PR_NUMBER: ${{ github.event.pull_request.number }}
352+
run: cargo set-version --offline --workspace 0.0.0-pr${PR_NUMBER}
351353
- name: Update version if PR against non-main branch
352354
# For PRs to be merged against a release branch, use the version that has already been set in the calling script.
353355
if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}
@@ -422,7 +424,9 @@ jobs:
422424
bin: cargo-set-version
423425
- name: Update version if PR against main branch
424426
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
425-
run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
427+
env:
428+
PR_NUMBER: ${{ github.event.pull_request.number }}
429+
run: cargo set-version --offline --workspace 0.0.0-pr${PR_NUMBER}
426430
- name: Update version if PR against non-main branch
427431
# For PRs to be merged against a release branch, use the version that has already been set in the calling script.
428432
if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}

0 commit comments

Comments
 (0)