Skip to content

Commit 1a6efb8

Browse files
committed
review feedback
1 parent 9889fb5 commit 1a6efb8

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

deploy/helm/spark-k8s-operator/crds/crds.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,10 @@ spec:
11191119
properties:
11201120
clusterConfig:
11211121
default: {}
1122-
description: Global Spark history server configuration that applies to all roles and role groups. Currently not in use.
1122+
description: |-
1123+
Global Spark history server configuration that applies to all roles.
1124+
1125+
This was previously used to hold the listener configuration, which has since moved to the role configuration.
11231126
type: object
11241127
image:
11251128
anyOf:
@@ -1867,7 +1870,10 @@ spec:
18671870
type: array
18681871
clusterConfig:
18691872
default: {}
1870-
description: Global Spark Connect server configuration that applies to all roles. Currently not in use.
1873+
description: |-
1874+
Global Spark Connect server configuration that applies to all roles.
1875+
1876+
This was previously used to hold the listener configuration, which has since moved to the server configuration.
18711877
type: object
18721878
clusterOperation:
18731879
default:

rust/operator-binary/src/connect/crd.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ pub mod versioned {
7979
pub image: ProductImage,
8080

8181
/// Global Spark Connect server configuration that applies to all roles.
82-
/// Currently not in use.
82+
///
83+
/// This was previously used to hold the listener configuration, which has since moved
84+
/// to the server configuration.
8385
#[serde(default)]
8486
pub cluster_config: v1alpha1::SparkConnectServerClusterConfig,
8587

rust/operator-binary/src/crd/history.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ pub mod versioned {
8181
pub struct SparkHistoryServerSpec {
8282
pub image: ProductImage,
8383

84-
/// Global Spark history server configuration that applies to all roles and role groups.
85-
/// Currently not in use.
84+
/// Global Spark history server configuration that applies to all roles.
85+
///
86+
/// This was previously used to hold the listener configuration, which has since moved
87+
/// to the role configuration.
8688
#[serde(default)]
8789
pub cluster_config: v1alpha1::SparkHistoryServerClusterConfig,
8890

0 commit comments

Comments
 (0)