add s3 comments

Author: razvan

tests/templates/kuttl/spark-connect/10-deploy-spark-connect.yaml.j2

@@ -36,6 +36,8 @@ spec:
   vectorAggregatorConfigMapName: vector-aggregator-discovery
 {% endif %}
   args:
+    # These are unfortunatly required to make the S3A connector work with MinIO
+    # I had expected the clients to be able to set these, but that is not the case.
     - --conf spark.hadoop.fs.s3a.aws.credentials.provider=org.apache.hadoop.fs.s3a.SimpleAWSCredentialsProvider
     - --conf spark.hadoop.fs.s3a.path.style.access=true
     - --conf spark.hadoop.fs.s3a.endpoint=http://minio:9000
@@ -46,8 +48,6 @@ spec:
         containers:
           - name: spark
             env:
-              - name: DEMO_GREETING
-                value: "Hello from the overlords"
               - name: AWS_ACCESS_KEY_ID
                 valueFrom:
                   secretKeyRef:

tests/templates/kuttl/spark-connect/20-run-connect-client.yaml.j2

@@ -15,15 +15,11 @@ data:
 
         print(f"Connecting to Spark Connect server at {remote}")
 
+        # Adding s3a configuration properties here has no effect unfortunately.
+        # They need to be set in the SparkConnectServer.
         spark = (
             SparkSession.builder.appName("SimpleSparkConnectApp")
             .remote(remote)
-            .config("spark.hadoop.fs.s3a.aws.credentials.provider", "org.apache.hadoop.fs.s3a.SimpleAWSCredentialsProvider")
-            .config("spark.hadoop.fs.s3a.path.style.access", "true")
-            .config("spark.hadoop.fs.s3a.endpoint", "http://minio:9000")
-            .config("spark.hadoop.fs.s3a.region", "us-east-1")
-            .config("spark.hadoop.fs.s3a.access.key", "spark")
-            .config("spark.hadoop.fs.s3a.secret.key", "sparkspark")
             .getOrCreate()
         )