chore: Add todo comments on unwraps

Author: NickLarsenNZ

rust/operator-binary/src/crd/logdir.rs

@@ -155,6 +155,7 @@ impl S3LogDir {
         let bucket = log_file_dir
             .bucket
             .clone()
+            // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
             .resolve(client, namespace.unwrap().as_str())
             .await
             .context(ConfigureS3Snafu)?;

rust/operator-binary/src/crd/mod.rs

@@ -838,6 +838,7 @@ impl v1alpha1::SparkApplication {
         product_config: &ProductConfigManager,
     ) -> Result<ValidatedRoleConfigByPropertyKind, Error> {
         let submit_conf = if self.spec.job.is_some() {
+            // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
             self.spec.job.as_ref().unwrap().clone()
         } else {
             CommonConfiguration {
@@ -847,6 +848,7 @@ impl v1alpha1::SparkApplication {
         };
 
         let driver_conf = if self.spec.driver.is_some() {
+            // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
             self.spec.driver.as_ref().unwrap().clone()
         } else {
             CommonConfiguration {
@@ -857,6 +859,7 @@ impl v1alpha1::SparkApplication {
 
         let executor_conf: RoleGroup<RoleConfigFragment, JavaCommonConfig> =
             if self.spec.executor.is_some() {
+                // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
                 self.spec.executor.as_ref().unwrap().clone()
             } else {
                 RoleGroup {

rust/operator-binary/src/history/history_controller.rs

@@ -629,6 +629,7 @@ fn build_service(
             Some("None".to_string()),
         ),
         None => (
+            // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
             format!("{}-{}", shs.metadata.name.as_ref().unwrap(), role),
             shs.spec.cluster_config.listener_class.k8s_service_type(),
             None,

rust/operator-binary/src/spark_k8s_controller.rs

@@ -233,6 +233,7 @@ pub async fn reconcile(
             s3bd.clone()
                 .resolve(
                     client,
+                    // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
                     spark_application.metadata.namespace.as_deref().unwrap(),
                 )
                 .await
@@ -350,6 +351,7 @@ pub async fn reconcile(
 
     let job_commands = spark_application
         .build_command(
+            // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
             serviceaccount.metadata.name.as_ref().unwrap(),
             &opt_s3conn,
             &logdir,
@@ -630,6 +632,7 @@ fn pod_template(
         logdir,
         spark_image,
     )
+    // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
     .unwrap();
 
     for init_container in init_containers {
@@ -968,6 +971,7 @@ fn build_spark_role_serviceaccount(
     spark_app: &v1alpha1::SparkApplication,
     spark_image: &ResolvedProductImage,
 ) -> Result<(ServiceAccount, RoleBinding)> {
+    // TODO (@NickLarsenNZ): Explain this unwrap. Either convert to expect, or gracefully handle the error.
     let sa_name = spark_app.metadata.name.as_ref().unwrap().to_string();
     let sa = ServiceAccount {
         metadata: ObjectMetaBuilder::new()