Skip to content

Commit f3158c9

Browse files
maltesanderrazvan
andauthored
Apply suggestions from code review
Co-authored-by: Razvan-Daniel Mihai <[email protected]>
1 parent 75f14a6 commit f3158c9

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

rust/operator-binary/src/connect/crd.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ pub mod versioned {
115115
/// Global role config settings for the Spark Connect Server.
116116
#[derive(Clone, Debug, JsonSchema, PartialEq, Serialize, Deserialize)]
117117
#[serde(rename_all = "camelCase")]
118-
pub struct SparkConnectServerRoleConfig {
118+
struct SparkConnectServerRoleConfig {
119119
/// This field controls which [ListenerClass](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listenerclass.html)
120120
/// is used to expose the Spark Connect services.
121121
#[serde(default = "default_listener_class")]

rust/operator-binary/src/connect/server.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,12 @@ pub(crate) fn build_listener(
633633
role_config: &v1alpha1::SparkConnectServerRoleConfig,
634634
resolved_product_image: &ResolvedProductImage,
635635
) -> Result<listener::v1alpha1::Listener, Error> {
636-
let listener_name = format!("{cluster}-server", cluster = scs.name_any());
636+
let listener_name = format!(
637+
"{cluster}-{role}",
638+
cluster = scs.name_any(),
639+
role = SparkConnectRole::Server
640+
);
641+
637642

638643
let listener_class = role_config.listener_class.clone();
639644
let role = SparkConnectRole::Server.to_string();

0 commit comments

Comments
 (0)