Skip to content

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Jul 4, 2025

Description

  • Moved History Server listenerClass to role config
  • Moved Spark Connect listenerClass to role config

SparkConnect services:

  • listener: <cluster-name>-server from <cluster-name>-server-default
  • headless: <cluster-name>-server-headless from <cluster-name>-server

SparkHistory services:

  • listener: <cluster-name>-node from <cluster-name>-node-default

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander marked this pull request as ready for review July 7, 2025 12:47
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Jul 7, 2025
@maltesander
Copy link
Member Author

@razvan razvan self-requested a review July 7, 2025 14:36
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 7, 2025
razvan
razvan previously approved these changes Jul 8, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Razvan-Daniel Mihai <[email protected]>
@NickLarsenNZ NickLarsenNZ merged commit a8055af into main Jul 8, 2025
16 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/move-listener-class-to-role-config branch July 8, 2025 14:26
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Jul 8, 2025
@lfrancke
Copy link
Member

Is this a breaking change or was this added to a different place in the 25.7 cycle in the first place?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jul 14, 2025
@razvan
Copy link
Member

razvan commented Jul 14, 2025

Is this a breaking change or was this added to a different place in the 25.7 cycle in the first place?

It is a breaking change from 25.3 because the CRD field has moved and the service name has changed.

@lfrancke
Copy link
Member

In that case: Do we have release notes for this somewhere already? If not, can you please add some?

@razvan
Copy link
Member

razvan commented Jul 14, 2025

In that case: Do we have release notes for this somewhere already? If not, can you please add some?

stackabletech/issues#692 (comment)

@maltesander
Copy link
Member Author

In that case: Do we have release notes for this somewhere already? If not, can you please add some?

Or stackabletech/issues#692 (comment)

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Integrate Spark Operator with Listener Operator

5 participants