Skip to content

chore: ensure metrics are correctly exposed #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maltesander merged 9 commits into from
Oct 17, 2025
Merged

chore: ensure metrics are correctly exposed #619

maltesander merged 9 commits into from
Oct 17, 2025

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Oct 16, 2025 •
edited
Loading

Description

Part of stackabletech/issues#747

  • add metrics service for spark history server
  • fixes examples
spark_history_target_health spark_connect_target_health

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Oct 16, 2025
@maltesander maltesander mentioned this pull request Oct 16, 2025
Closed
16 tasks
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Oct 16, 2025
@razvan razvan self-requested a review October 16, 2025 12:29
@razvan
Copy link
Member

razvan commented Oct 17, 2025

🟢 CI https://testing.stackable.tech/job/spark-k8s-operator-it-custom/47/display/redirect

razvan
razvan approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Oct 17, 2025
@maltesander maltesander moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Oct 17, 2025
Merged via the queue into main with commit c8e849f Oct 17, 2025
17 checks passed
@maltesander maltesander deleted the chore/ensure-metrics-correctly-exposed branch October 17, 2025 07:08
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 24, 2025
@lfrancke
Copy link
Member

lfrancke commented Nov 4, 2025

Could you please add release notes?

@maltesander
Copy link
Member Author

maltesander commented Nov 5, 2025

Release snippet

Previously, the spark-k8s-operator did not expose Prometheus annotations containing the http(s) scheme or the metrics path and port for Spark Connect or the Spark HistoryServer metrics service. This was added in this PR and allows custom relabel configs in Prometheus to use these annotations to scrape the metric endpoints.

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.11.0 labels Nov 11, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels

release/25.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maltesander @razvan @lfrancke