use Debug impl for String in Errors

Author: xeniape

rust/stackable-cockpit/src/engine/minikube/mod.rs

@@ -10,7 +10,7 @@ use crate::{
 #[derive(Debug, Snafu)]
 pub enum Error {
     #[snafu(display(
-        "failed to determine if a Minikube cluster named '{cluster_name}' already exists"
+        "failed to determine if a Minikube cluster named {cluster_name:?} already exists"
     ))]
     CheckCluster {
         source: std::io::Error,

rust/stackable-cockpit/src/platform/demo/spec.rs

@@ -29,13 +29,13 @@ pub type DemoParameter = Parameter;
 
 #[derive(Debug, Snafu)]
 pub enum Error {
-    #[snafu(display("no stack named '{name}'"))]
+    #[snafu(display("no stack named {name:?}"))]
     NoSuchStack { name: String },
 
     #[snafu(display("demo resource requests error"), context(false))]
     DemoResourceRequests { source: ResourceRequestsError },
 
-    #[snafu(display("cannot install demo in namespace '{requested}', only '{}' supported", supported.join(", ")))]
+    #[snafu(display("cannot install demo in namespace {requested:?}, only '{}' supported", supported.join(", ")))]
     UnsupportedNamespace {
         requested: String,
         supported: Vec<String>,

rust/stackable-cockpit/src/platform/service.rs

@@ -20,22 +20,22 @@ pub enum Error {
     #[snafu(display("failed to fetch data from Kubernetes API"))]
     KubeClientFetch { source: k8s::Error },
 
-    #[snafu(display("missing namespace for service '{service}'"))]
+    #[snafu(display("missing namespace for service {service:?}"))]
     MissingServiceNamespace { service: String },
 
-    #[snafu(display("missing spec for service '{service}'"))]
+    #[snafu(display("missing spec for service {service:?}"))]
     MissingServiceSpec { service: String },
 
-    #[snafu(display("failed to get status of node '{node_name}'"))]
+    #[snafu(display("failed to get status of node {node_name:?}"))]
     GetNodeStatus { node_name: String },
 
-    #[snafu(display("failed to get address of node '{node_name}'"))]
+    #[snafu(display("failed to get address of node {node_name:?}"))]
     GetNodeAddress { node_name: String },
 
-    #[snafu(display("failed to find an ExternalIP or InternalIP for node '{node_name}'"))]
+    #[snafu(display("failed to find an ExternalIP or InternalIP for node {node_name:?}"))]
     NoIpForNode { node_name: String },
 
-    #[snafu(display("failed to find node '{node_name}' in node_name_ip_mapping"))]
+    #[snafu(display("failed to find node {node_name:?} in node_name_ip_mapping"))]
     NodeMissingInIpMapping { node_name: String },
 }
 

rust/stackable-cockpit/src/platform/stacklet/mod.rs

@@ -50,7 +50,7 @@ pub enum Error {
     #[snafu(display("failed to fetch data from the Kubernetes API"))]
     KubeClientFetch { source: k8s::Error },
 
-    #[snafu(display("no namespace set for custom resource '{crd_name}'"))]
+    #[snafu(display("no namespace set for custom resource {crd_name:?}"))]
     CustomCrdNamespace { crd_name: String },
 
     #[snafu(display("failed to deserialize cluster conditions from JSON"))]

rust/stackable-cockpit/src/utils/k8s/client.rs

@@ -64,19 +64,19 @@ pub enum Error {
     #[snafu(display("failed to convert byte string into UTF-8 string"))]
     ByteStringConvert { source: FromUtf8Error },
 
-    #[snafu(display("missing namespace for service '{service}'"))]
+    #[snafu(display("missing namespace for service {service:?}"))]
     MissingServiceNamespace { service: String },
 
     #[snafu(display("failed to retrieve cluster information"))]
     ClusterInformation { source: cluster::Error },
 
-    #[snafu(display("invalid or empty secret data in '{secret_name}'"))]
+    #[snafu(display("invalid or empty secret data in {secret_name:?}"))]
     InvalidSecretData { secret_name: String },
 
-    #[snafu(display("no username key in credentials secret '{secret_name}'"))]
+    #[snafu(display("no username key in credentials secret {secret_name:?}"))]
     NoUsernameKey { secret_name: String },
 
-    #[snafu(display("no password key in credentials secret '{secret_name}'"))]
+    #[snafu(display("no password key in credentials secret {secret_name:?}"))]
     NoPasswordKey { secret_name: String },
 }
 

rust/stackable-cockpit/src/utils/params.rs

@@ -34,7 +34,7 @@ pub enum IntoParametersError {
     #[snafu(display("failed to parse raw parameter"))]
     RawParse { source: RawParameterParseError },
 
-    #[snafu(display("invalid parameter '{parameter}', expected one of {expected}"))]
+    #[snafu(display("invalid parameter {parameter:?}, expected one of {expected:?}"))]
     InvalidParameter { parameter: String, expected: String },
 }
 

rust/stackablectl/src/cmds/demo.rs

@@ -125,13 +125,13 @@ pub enum CmdError {
     #[snafu(display("failed to serialize JSON output"))]
     SerializeJsonOutput { source: serde_json::Error },
 
-    #[snafu(display("no demo with name '{name}'"))]
+    #[snafu(display("no demo with name {name:?}"))]
     NoSuchDemo { name: String },
 
-    #[snafu(display("no stack with name '{name}'"))]
+    #[snafu(display("no stack with name {name:?}"))]
     NoSuchStack { name: String },
 
-    #[snafu(display("no release '{release}'"))]
+    #[snafu(display("no release {release:?}"))]
     NoSuchRelease { release: String },
 
     #[snafu(display("failed to get latest release"))]

rust/stackablectl/src/cmds/operator.rs

@@ -141,7 +141,7 @@ pub enum CmdError {
         version: String,
     },
 
-    #[snafu(display("unknown repository name '{name}'"))]
+    #[snafu(display("unknown repository name {name:?}"))]
     UnknownRepoName { name: String },
 
     #[snafu(display("Helm error"))]
@@ -159,7 +159,7 @@ pub enum CmdError {
     #[snafu(display("failed to create Kubernetes client"))]
     KubeClientCreate { source: k8s::Error },
 
-    #[snafu(display("failed to create namespace '{namespace}'"))]
+    #[snafu(display("failed to create namespace {namespace:?}"))]
     NamespaceCreate {
         source: namespace::Error,
         namespace: String,

rust/stackablectl/src/cmds/release.rs

@@ -140,7 +140,7 @@ pub enum CmdError {
     #[snafu(display("failed to build release list"))]
     BuildList { source: list::Error },
 
-    #[snafu(display("no release '{release}'"))]
+    #[snafu(display("no release {release:?}"))]
     NoSuchRelease { release: String },
 
     #[snafu(display("failed to install release"))]
@@ -158,7 +158,7 @@ pub enum CmdError {
     #[snafu(display("failed to create Kubernetes client"))]
     KubeClientCreate { source: k8s::Error },
 
-    #[snafu(display("failed to create namespace '{namespace}'"))]
+    #[snafu(display("failed to create namespace {namespace:?}"))]
     NamespaceCreate {
         source: namespace::Error,
         namespace: String,

rust/stackablectl/src/cmds/stack.rs

@@ -121,7 +121,7 @@ pub enum CmdError {
     #[snafu(display("failed to serialize JSON output"))]
     SerializeJsonOutput { source: serde_json::Error },
 
-    #[snafu(display("no release '{release}'"))]
+    #[snafu(display("no release {release:?}"))]
     NoSuchRelease { release: String },
 
     #[snafu(display("failed to get latest release"))]