feat: Support OCI registries

Author: adwk67

rust/stackable-cockpit/src/constants.rs

@@ -22,6 +22,8 @@ pub const HELM_REPO_NAME_TEST: &str = "stackable-test";
 pub const HELM_REPO_NAME_DEV: &str = "stackable-dev";
 pub const HELM_REPO_INDEX_FILE: &str = "index.yaml";
 
+pub const HELM_OCI_REGISTRY: &str = "oci://oci.stackable.tech/sdp-charts";
+
 pub const HELM_DEFAULT_CHART_VERSION: &str = ">0.0.0-0";
 
 pub const PRODUCT_NAMES: &[&str] = &[

rust/stackable-cockpit/src/helm.rs

@@ -182,20 +182,20 @@ impl Display for UninstallReleaseStatus {
 }
 
 pub struct ChartVersion<'a> {
-    pub repo_name: &'a str,
+    pub chart_source: &'a str,
     pub chart_name: &'a str,
     pub chart_version: Option<&'a str>,
 }
 
-/// Installs a Helm release from a repo.
+/// Installs a Helm release from a repo or registry.
 ///
 /// This function expects the fully qualified Helm release name. In case of our
 /// operators this is: `<PRODUCT_NAME>-operator`.
 #[instrument]
-pub fn install_release_from_repo(
+pub fn install_release_from_repo_or_registry(
     release_name: &str,
     ChartVersion {
-        repo_name,
+        chart_source,
         chart_name,
         chart_version,
     }: ChartVersion,
@@ -244,7 +244,7 @@ pub fn install_release_from_repo(
             }
         }
 
-        let full_chart_name = format!("{repo_name}/{chart_name}");
+        let full_chart_name = format!("{chart_source}/{chart_name}");
         let chart_version = chart_version.unwrap_or(HELM_DEFAULT_CHART_VERSION);
 
         debug!(

rust/stackable-cockpit/src/platform/demo/params.rs

@@ -10,4 +10,5 @@ pub struct DemoInstallParameters {
 
     pub stack_labels: Labels,
     pub labels: Labels,
+    pub use_registry: bool,
 }

rust/stackable-cockpit/src/platform/demo/spec.rs

@@ -159,6 +159,7 @@ impl DemoSpec {
             skip_release: install_parameters.skip_release,
             stack_name: self.stack.clone(),
             demo_name: None,
+            use_registry: install_parameters.use_registry,
         };
 
         stack

rust/stackable-cockpit/src/platform/manifests.rs

@@ -62,6 +62,7 @@ pub enum Error {
 
 pub trait InstallManifestsExt {
     // TODO (Techassi): This step shouldn't care about templating the manifests nor fetching them from remote
+    // TODO aken: do we support helm charts from registries?
     #[instrument(skip_all)]
     #[allow(async_fn_in_trait)]
     async fn install_manifests(
@@ -94,6 +95,7 @@ pub trait InstallManifestsExt {
                         helm_chart.name, helm_chart.version
                     );
 
+                    // TODO aken: assuming all manifest helm charts refer to repos not registries
                     helm::add_repo(&helm_chart.repo.name, &helm_chart.repo.url).context(
                         AddHelmRepositorySnafu {
                             repo_name: helm_chart.repo.name.clone(),
@@ -105,10 +107,10 @@ pub trait InstallManifestsExt {
                         .context(SerializeOptionsSnafu)?;
 
                     // Install the Helm chart using the Helm wrapper
-                    helm::install_release_from_repo(
+                    helm::install_release_from_repo_or_registry(
                         &helm_chart.release_name,
                         helm::ChartVersion {
-                            repo_name: &helm_chart.repo.name,
+                            chart_source: &helm_chart.repo.name,
                             chart_name: &helm_chart.name,
                             chart_version: Some(&helm_chart.version),
                         },

rust/stackable-cockpit/src/platform/operator/mod.rs

@@ -5,7 +5,9 @@ use snafu::{ensure, ResultExt, Snafu};
 use tracing::{info, instrument};
 
 use crate::{
-    constants::{HELM_REPO_NAME_DEV, HELM_REPO_NAME_STABLE, HELM_REPO_NAME_TEST},
+    constants::{
+        HELM_OCI_REGISTRY, HELM_REPO_NAME_DEV, HELM_REPO_NAME_STABLE, HELM_REPO_NAME_TEST,
+    },
     helm,
     utils::operator_chart_name,
 };
@@ -176,20 +178,25 @@ impl OperatorSpec {
 
     /// Installs the operator using Helm.
     #[instrument(skip_all)]
-    pub fn install(&self, namespace: &str) -> Result<(), helm::Error> {
+    pub fn install(&self, namespace: &str, use_registry: bool) -> Result<(), helm::Error> {
         info!("Installing operator {}", self);
 
         let version = self.version.as_ref().map(|v| v.to_string());
-        let helm_repo = self.helm_repo_name();
         let helm_name = self.helm_name();
 
+        let chart_source = if use_registry {
+            HELM_OCI_REGISTRY.to_string()
+        } else {
+            self.helm_repo_name()
+        };
+
         // Install using Helm
-        helm::install_release_from_repo(
+        helm::install_release_from_repo_or_registry(
             &helm_name,
             helm::ChartVersion {
                 chart_version: version.as_deref(),
                 chart_name: &helm_name,
-                repo_name: &helm_repo,
+                chart_source: &chart_source,
             },
             None,
             namespace,

rust/stackable-cockpit/src/platform/release/spec.rs

@@ -56,6 +56,7 @@ impl ReleaseSpec {
         include_products: &[String],
         exclude_products: &[String],
         namespace: &str,
+        use_registry: bool,
     ) -> Result<()> {
         info!("Installing release");
 
@@ -73,7 +74,9 @@ impl ReleaseSpec {
                         .context(OperatorSpecParseSnafu)?;
 
                     // Install operator
-                    operator.install(&namespace).context(HelmInstallSnafu)?;
+                    operator
+                        .install(&namespace, use_registry)
+                        .context(HelmInstallSnafu)?;
 
                     info!("Installed {product_name}-operator");
 

rust/stackable-cockpit/src/platform/stack/params.rs

@@ -11,4 +11,5 @@ pub struct StackInstallParameters {
     pub parameters: Vec<String>,
     pub skip_release: bool,
     pub labels: Labels,
+    pub use_registry: bool,
 }

rust/stackable-cockpit/src/platform/stack/spec.rs

@@ -173,6 +173,7 @@ impl StackSpec {
                 release_list,
                 &install_parameters.operator_namespace,
                 &install_parameters.product_namespace,
+                install_parameters.use_registry,
             )
             .await?;
         }
@@ -195,6 +196,7 @@ impl StackSpec {
         release_list: release::ReleaseList,
         operator_namespace: &str,
         product_namespace: &str,
+        use_registry: bool,
     ) -> Result<(), Error> {
         info!("Trying to install release {}", self.release);
 
@@ -207,7 +209,7 @@ impl StackSpec {
 
         // Install the release
         release
-            .install(&self.operators, &[], operator_namespace)
+            .install(&self.operators, &[], operator_namespace, use_registry)
             .await
             .context(InstallReleaseSnafu)
     }

rust/stackablectl/src/cmds/demo.rs

@@ -107,6 +107,10 @@ to specify operator versions."
 
     #[command(flatten)]
     namespaces: CommonNamespaceArgs,
+
+    /// TODO
+    #[arg(long, long_help = "TODO")]
+    use_registry: bool,
 }
 
 #[derive(Debug, Args)]
@@ -329,6 +333,7 @@ async fn install_cmd(
         skip_release: args.skip_release,
         stack_labels,
         labels,
+        use_registry: args.use_registry,
     };
 
     demo.install(