Skip to content

Commit 6a51203

Browse files
committed
Merge branch 'feature/abitrary-python-imports' of https://github.com/stackabletech/superset-operator into feature/abitrary-python-imports
2 parents 4b64920 + 1db84f1 commit 6a51203

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
- Reduce CRD size from `472KB` to `45KB` by accepting arbitrary YAML input instead of the underlying schema for the following fields ([#528]):
1212
- `podOverrides`
1313
- `affinity`
14-
- Bumping stackable-operator from 0.73.0 to 0.74.0 ([#530])
1514

1615
[#528]: https://github.com/stackabletech/superset-operator/pull/528
1716
[#530]: https://github.com/stackabletech/superset-operator/pull/530

rust/operator-binary/src/superset_controller.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,10 +533,11 @@ fn build_rolegroup_config_map(
533533

534534
let mut config_file = Vec::new();
535535

536+
// By removing the keys from `config_properties`, we avoid pasting the Python code into a Python variable as well
537+
// (which would be bad)
536538
if let Some(header) = config_properties.remove(CONFIG_OVERRIDE_FILE_HEADER_KEY) {
537539
writeln!(config_file, "{}", header).context(WriteToConfigFileStringSnafu)?;
538540
}
539-
// removing key from `config_properties` to avoid key value match. Append it later.
540541
let temp_file_footer = config_properties.remove(CONFIG_OVERRIDE_FILE_FOOTER_KEY);
541542

542543
flask_app_config_writer::write::<SupersetConfigOptions, _, _>(

0 commit comments

Comments
 (0)