Removing some ToDo's. Better comments

Author: Maleware

rust/crd/src/lib.rs

@@ -138,11 +138,11 @@ impl FlaskAppConfigOptions for SupersetConfigOptions {
             SupersetConfigOptions::AuthLdapTlsCertfile => PythonType::StringLiteral,
             SupersetConfigOptions::AuthLdapTlsKeyfile => PythonType::StringLiteral,
             SupersetConfigOptions::AuthLdapTlsCacertfile => PythonType::StringLiteral,
+            // Configuration options used by CustomOpaSecurityManager
             SupersetConfigOptions::CustomSecurityManager => PythonType::Expression,
             SupersetConfigOptions::StackableOpaBaseUrl => PythonType::StringLiteral,
             SupersetConfigOptions::StackableOpaPackage => PythonType::StringLiteral,
             SupersetConfigOptions::StackableOpaRule => PythonType::Expression,
-            // TODO: Set new options for OpaSecurityManager like:
         }
     }
 }

rust/operator-binary/src/authorization/opa.rs

@@ -22,7 +22,7 @@ impl SupersetOpaConfig {
             .full_document_url_from_config_map(client, superset, None, OpaApiVersion::V1)
             .await?;
 
-        // striping package path from base url. Needed by CustomOpaSecurityManager. TODO: <Path/to/manager.py>
+        // striping package path from base url. Needed by CustomOpaSecurityManager.
         let opa_base_url = match opa_config.package.clone() {
             Some(opa_package_name) => {
                 let opa_path = format!("/v1/data/{opa_package_name}");
@@ -38,24 +38,20 @@ impl SupersetOpaConfig {
     }
 
     // Adding necessary configurations. Imports are solved in config.rs
-    // TODO: Currently: .unwrap_or_default() which ends in e.g. :
-    // CUSTOM_SECURITY_MANAGER = None => CUSTOM_SECURITY_MANAGER = ""
-    // Could be better if not set.
     pub fn as_config(&self) -> BTreeMap<String, Option<String>> {
         BTreeMap::from([
             (
                 "CUSTOM_SECURITY_MANAGER".to_string(),
                 Some("OpaSupersetSecurityManager".to_string()),
             ),
             // This is now a PythonType::Expression. Makes it easy to find a default.
-            // only necessary when opa role mapping is activated, as the user
-            // has to have a role to be valid.
+            // EnvOverrides are supported.
             (
                 "AUTH_USER_REGISTRATION_ROLE".to_string(),
                 Some("os.getenv('AUTH_USER_REGISTRATION_ROLE', 'Public')".to_string()),
             ),
             // There is no proper way to interfere this without changing e.g. CRD's.
-            // Thus, we go for an default and make it accessible through envOverrides.
+            // EnvOverrides are supported.
             // TODO: Documentation
             (
                 "STACKABLE_OPA_RULE".to_string(),