From 379f9a907375c0002cddc24f3400f7134c0d63d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 24 Oct 2024 17:06:02 +0200 Subject: [PATCH 1/4] Demote reviewdog to a check, not review --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0c58d98e..8b7be5f7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -162,7 +162,6 @@ jobs: if: env.GITHUB_TOKEN != null with: clippy_flags: --all-targets -- -D warnings - reporter: 'github-pr-review' github_token: ${{ secrets.GITHUB_TOKEN }} - name: Run clippy manually without annotations env: From 27da64cb60ec0df27f942e2a0b3a7ba3ab91d530 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 24 Oct 2024 17:06:32 +0200 Subject: [PATCH 2/4] Intentionally break the build --- rust/operator-binary/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/operator-binary/src/main.rs b/rust/operator-binary/src/main.rs index 88afd730..5284ca52 100644 --- a/rust/operator-binary/src/main.rs +++ b/rust/operator-binary/src/main.rs @@ -37,8 +37,8 @@ mod built_info { include!(concat!(env!("OUT_DIR"), "/built.rs")); } -pub const APP_PORT: u16 = 8088; -pub const OPERATOR_NAME: &str = "superset.stackable.tech"; +// pub const APP_PORT: u16 = 8088; +// pub const OPERATOR_NAME: &str = "superset.stackable.tech"; #[derive(Parser)] #[clap(about, author)] From 64f6457353c864cf7922d30c2f3d6499a2113810 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 24 Oct 2024 17:10:54 +0200 Subject: [PATCH 3/4] Disable rust cache? --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8b7be5f7..a438c132 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -154,7 +154,7 @@ jobs: - uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3 with: key: clippy - cache-all-crates: "true" + # cache-all-crates: "true" - name: Run clippy action to produce annotations uses: giraffate/clippy-action@13b9d32482f25d29ead141b79e7e04e7900281e0 # v1.0.1 env: From 08afb217425c58cc8b4904ace0e800598e346c87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natalie=20Klestrup=20R=C3=B6ijezon?= Date: Thu, 24 Oct 2024 17:16:37 +0200 Subject: [PATCH 4/4] Pick up all Clippy errors, not just for modified lines --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a438c132..f7919216 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -154,7 +154,7 @@ jobs: - uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3 with: key: clippy - # cache-all-crates: "true" + cache-all-crates: "true" - name: Run clippy action to produce annotations uses: giraffate/clippy-action@13b9d32482f25d29ead141b79e7e04e7900281e0 # v1.0.1 env: @@ -163,6 +163,8 @@ jobs: with: clippy_flags: --all-targets -- -D warnings github_token: ${{ secrets.GITHUB_TOKEN }} + fail_on_error: true + filter_mode: nofilter - name: Run clippy manually without annotations env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}