fix: fixed review feedback

Author: dervoeti

examples/simple-trino-cluster-fault-tolerant-execution.yaml renamed to docs/modules/trino/examples/usage-guide/fault-tolerant-execution.yaml

@@ -1,5 +1,3 @@
-# stackablectl operator install commons secret listener trino
-# helm install minio minio --repo https://charts.bitnami.com/bitnami --version 15.0.7 --set auth.rootUser=minio-access-key --set auth.rootPassword=minio-secret-key --set tls.enabled=true --set tls.existingSecret=minio-tls-certificates --set provisioning.enabled=true --set provisioning.buckets[0].name=trino-exchange-bucket
 ---
 apiVersion: trino.stackable.tech/v1alpha1
 kind: TrinoCluster
@@ -17,7 +15,7 @@ spec:
       taskRetryAttemptsPerTask: 4
       retryInitialDelay: 10s
       retryMaxDelay: 60s
-      retryDelayScaleFactor: "2.0"
+      retryDelayScaleFactor: 2.0
       exchangeDeduplicationBufferSize: 64MB
       exchangeEncryptionEnabled: true
       exchangeManager:
@@ -107,3 +105,4 @@ metadata:
 spec:
   connector:
     tpch: {}
+

docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc

@@ -61,6 +61,7 @@ This policy is recommended when executing large batch queries, as the cluster ca
 
 IMPORTANT: A `TASK` retry policy is best suited for long-running queries, but this policy can result in higher latency for short-running queries executed in high volume.
 As a best practice, it is recommended to run a dedicated cluster with a `TASK` retry policy for large batch queries, separate from another cluster that handles short queries.
+There are tools that can help you achieve this by automatically routing queries based on certain criteria (such as query estimates or user) to different Trino clusters. Notable mentions are link:https://github.com/stackabletech/trino-lb[trino-lb {external-link-icon}^] and link:https://github.com/trinodb/trino-gateway[trino-gateway {external-link-icon}^].
 
 [source,yaml]
 ----
@@ -273,7 +274,7 @@ spec:
     - ReadWriteOnce
   resources:
     requests:
-      storage: 10Gi
+      storage: 50Gi
 ----
 
 == Connector support
@@ -283,6 +284,17 @@ Take a look at the link:https://trino.io/docs/current/admin/fault-tolerant-execu
 
 When using connectors that do not explicitly support fault-tolerant execution, you may encounter a "This connector does not support query retries" error message.
 
-== Examples
+== Example
 
-* link:https://github.com/stackabletech/trino-operator/blob/main/examples/simple-trino-cluster-fault-tolerant-execution.yaml[TrinoCluster with TASK retry policy and S3 exchange manager {external-link-icon}^]
+Here's an example of a Trino cluster with fault-tolerant execution enabled using the `TASK` retry policy and MinIO backed S3 as the exchange manager:
+
+[source,bash]
+----
+stackablectl operator install commons secret listener trino
+helm install minio minio --repo https://charts.bitnami.com/bitnami --version 15.0.7 --set auth.rootUser=minio-access-key --set auth.rootPassword=minio-secret-key --set tls.enabled=true --set tls.existingSecret=minio-tls-certificates --set provisioning.enabled=true --set provisioning.buckets[0].name=trino-exchange-bucket
+----
+
+[source,yaml]
+----
+include::example$usage-guide/fault-tolerant-execution.yaml[]
+----

rust/operator-binary/src/crd/fault_tolerant_execution.rs

@@ -25,7 +25,7 @@ use crate::{
     crd::{CONFIG_DIR_NAME, STACKABLE_CLIENT_TLS_DIR},
 };
 
-#[derive(Clone, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct FaultTolerantExecutionConfig {
     /// The retry policy for fault tolerant execution.
@@ -58,7 +58,7 @@ pub struct FaultTolerantExecutionConfig {
 
     /// Factor by which retry delay is increased on each query or task failure.
     #[serde(skip_serializing_if = "Option::is_none")]
-    pub retry_delay_scale_factor: Option<String>,
+    pub retry_delay_scale_factor: Option<f32>,
 
     /// Data size of the coordinator's in-memory buffer used to store output of query stages.
     #[serde(skip_serializing_if = "Option::is_none")]
@@ -70,7 +70,7 @@ pub struct FaultTolerantExecutionConfig {
 }
 
 #[derive(Clone, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]
-#[serde(rename_all = "SCREAMING_SNAKE_CASE")]
+#[serde(rename_all = "camelCase")]
 pub enum RetryPolicy {
     /// Retry entire queries on failure
     Query,
@@ -117,16 +117,12 @@ pub struct ExchangeManagerGeneralConfig {
 #[serde(rename_all = "camelCase")]
 pub enum ExchangeManagerBackend {
     /// S3-compatible storage configuration (includes AWS S3, MinIO, GCS).
-    #[serde(rename = "s3")]
     S3(S3ExchangeConfig),
     /// Azure Blob Storage configuration.
-    #[serde(rename = "azure")]
     Azure(AzureExchangeConfig),
     /// HDFS-based exchange manager.
-    #[serde(rename = "hdfs")]
     Hdfs(HdfsExchangeConfig),
     /// Local filesystem storage (not recommended for production).
-    #[serde(rename = "local")]
     Local(LocalExchangeConfig),
 }
 
@@ -646,7 +642,7 @@ mod tests {
             task_retry_attempts_per_task: None,
             retry_initial_delay: Some(Duration::from_secs(15)),
             retry_max_delay: Some(Duration::from_secs(90)),
-            retry_delay_scale_factor: Some("3.0".to_string()),
+            retry_delay_scale_factor: Some(3.0),
             exchange_deduplication_buffer_size: Some("64MB".to_string()),
             exchange_encryption_enabled: Some(false),
         };
@@ -674,7 +670,7 @@ mod tests {
         );
         assert_eq!(
             fte_config.config_properties.get("retry-delay-scale-factor"),
-            Some(&"3.0".to_string())
+            Some(&"3".to_string())
         );
         assert_eq!(
             fte_config