Support overriding Trino's liveness probe with other probe type

[ay4m]

Affected Stackable version

23.7.0

Affected Trino version

414

Current and expected behavior

I want to override livenessProbe because of some memory issues. This is what i want it to be

workers:
  podOverrides:
      spec:
        containers:
        - name: trino
          livenessProbe:
            exec:
              command:
                - /bin/sh
                - -c
                - |
                  #!/bin/sh
                  mem_total=$(grep MemTotal /proc/meminfo | awk '{print $2}')
                  mem_available=$(grep MemAvailable /proc/meminfo | awk '{print $2}')
                  used_percent=$(( (100 * (mem_total - mem_available)) / mem_total ))
                  echo "Node memory usage: ${used_percent}%"
                  if [ "$used_percent" -gt 94 ]; then
                    echo "Node memory usage above 94% — failing liveness probe."
                    exit 1
                  fi

                  # TCP socket check (simulate original)
                  timeout 2 bash -c 'cat < /dev/null > /dev/tcp/127.0.0.1/8080' || exit 1
            periodSeconds: 30
            failureThreshold: 2
            timeoutSeconds: 10

but i get this error in message in my trino worker statefulset:

create Pod trino-coac-worker-default-0 in StatefulSet trino-coac-worker-default failed error: Pod "trino-coac-worker-default-0" is invalid: spec.containers[0].livenessProbe.tcpSocket: Forbidden: may not specify more than 1 handler type

looks like it doesn't really override the livenessProbe as the tcpSocket field still exists?

Possible solution

No response

Additional context

No response

Environment

No response

Would you like to work on fixing this bug?

None

[sbernauer]

Hi! Yes, you are pointing out a problem with our merging functionality.
We are using https://docs.rs/k8s-openapi/latest/k8s_openapi/trait.DeepMerge.html internally. Basically you can only add or override fields on structs, but not delete them.
If you have any ideas how we can ergonomically improve that (to allow deleting fields), that would be great!
PS: I actually ran into the exact same issue with probes in the past as well...