Skip to content

Conversation

dervoeti
Copy link
Member

Description

Part of stackabletech/docker-images#1235

I also updated some examples to use credentialsSecret since they failed to apply.

Tests passed:

--- PASS: kuttl (205.14s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/opa-authorization_trino-477_hive-latest-4.1.0_opa-1.8.0_keycloak-25.0.0_openshift-false (205.11s)

--- PASS: kuttl (385.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-477_hive-4.1.0_opa-1.8.0_hdfs-3.4.2_zookeeper-3.9.4_openshift-false (385.62s)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just one place where we could do with an explanation.

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 15, 2025
@dervoeti
Copy link
Member Author

lgtm - just one place where we could do with an explanation.

Thank you! That was an accidental change I committed, I used that local image for testing purposes. Fixed by cdfbb0d.

@dervoeti dervoeti requested a review from adwk67 October 20, 2025 07:04
@dervoeti dervoeti enabled auto-merge October 20, 2025 07:07
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 20, 2025
@dervoeti dervoeti added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 06dab8c Oct 20, 2025
69 of 77 checks passed
@dervoeti dervoeti deleted the chore/bump-to-hive-4.1.0 branch October 20, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants