chore: Handle errors properly

Author: NickLarsenNZ

rust/operator-binary/src/listener.rs

@@ -16,6 +16,12 @@ type Result<T, E = Error> = std::result::Result<T, E>;
 
 #[derive(Snafu, Debug)]
 pub enum Error {
+    #[snafu(display("Role {zk_role:?} is not defined in the ZooKeeperCluster spec"))]
+    InvalidRole {
+        source: crate::crd::Error,
+        zk_role: String,
+    },
+
     #[snafu(display("object is missing metadata to build owner reference"))]
     ObjectMissingMetadataForOwnerRef {
         source: stackable_operator::builder::meta::Error,
@@ -33,11 +39,12 @@ pub fn build_role_listener(
     resolved_product_image: &ResolvedProductImage,
     zookeeper_security: &ZookeeperSecurity,
 ) -> Result<listener::v1alpha1::Listener> {
-    // TODO (@NickLarsenNZ): Move this to a common function that takes a zk and a zk_role so that we can use it in other places like the PVC generation
     let listener_name = role_listener_name(zk, zk_role);
     let listener_class = &zk
         .role(zk_role)
-        .expect("handle error: valid role")
+        .with_context(|_| InvalidRoleSnafu {
+            zk_role: zk_role.to_string(),
+        })?
         .role_config
         .listener_class;
 

rust/operator-binary/src/zk_controller.rs

@@ -834,8 +834,7 @@ fn build_server_rolegroup_statefulset(
         &rolegroup_ref.role,
         &rolegroup_ref.role_group,
     ))
-    .expect("todo: LabelBuildSnafu");
-    // .context(LabelBuildSnafu)?;
+    .context(BuildLabelSnafu)?;
 
     let listener_pvc = build_role_listener_pvc(
         &role_listener_name(zk, &ZookeeperRole::Server),
@@ -970,6 +969,7 @@ fn build_server_rolegroup_statefulset(
             period_seconds: Some(1),
             ..Probe::default()
         })
+        // TODO (@NickLarsenNZ): Use consts for the port names (since they are used in multiple places)
         .add_container_port("zk", zookeeper_security.client_port().into())
         .add_container_port("zk-leader", ZOOKEEPER_LEADER_PORT as i32)
         .add_container_port("zk-election", ZOOKEEPER_ELECTION_PORT as i32)

rust/operator-binary/src/znode_controller.rs

@@ -274,6 +274,7 @@ async fn reconcile_apply(
         &znode.object_ref(&()),
         ClusterResourceApplyStrategy::from(&zk.spec.cluster_operation),
     )
+    // TODO (@NickLarsenNZ): Handle this error properly. znode should contain namespace/name, but there is no guarantee
     .unwrap();
 
     znode_mgmt::ensure_znode_exists(