@@ -22,12 +22,8 @@ use stackable_operator::{
2222 } ,
2323 logging:: controller:: report_controller_reconciled,
2424 shared:: yaml:: SerializeOptions ,
25- telemetry:: {
26- Tracing ,
27- tracing:: { RollingPeriod , settings:: Settings } ,
28- } ,
25+ telemetry:: Tracing ,
2926} ;
30- use tracing:: level_filters:: LevelFilter ;
3127
3228use crate :: { zk_controller:: ZK_FULL_CONTROLLER_NAME , znode_controller:: ZNODE_FULL_CONTROLLER_NAME } ;
3329
@@ -45,9 +41,6 @@ mod built_info {
4541 include ! ( concat!( env!( "OUT_DIR" ) , "/built.rs" ) ) ;
4642}
4743
48- // TODO (@NickLarsenNZ): Change the variable to `CONSOLE_LOG`
49- pub const ENV_VAR_CONSOLE_LOG : & str = "ZOOKEEPER_OPERATOR_LOG" ;
50-
5144#[ derive( clap:: Parser ) ]
5245#[ clap( about, author) ]
5346struct Opts {
@@ -71,42 +64,12 @@ async fn main() -> anyhow::Result<()> {
7164 telemetry_arguments,
7265 cluster_info_opts,
7366 } ) => {
74- let _tracing_guard = Tracing :: builder ( )
75- . service_name ( "zookeeper-operator" )
76- . with_console_output ( (
77- ENV_VAR_CONSOLE_LOG ,
78- LevelFilter :: INFO ,
79- !telemetry_arguments. no_console_output ,
80- ) )
81- // NOTE (@NickLarsenNZ): Before stackable-telemetry was used, the log directory was
82- // set via an env: `ZOOKEEPER_OPERATOR_LOG_DIRECTORY`.
83- // See: https://github.com/stackabletech/operator-rs/blob/f035997fca85a54238c8de895389cc50b4d421e2/crates/stackable-operator/src/logging/mod.rs#L40
84- // Now it will be `ROLLING_LOGS` (or via `--rolling-logs <DIRECTORY>`).
85- . with_file_output ( telemetry_arguments. rolling_logs . map ( |log_directory| {
86- let rotation_period = telemetry_arguments
87- . rolling_logs_period
88- . unwrap_or ( RollingPeriod :: Never )
89- . clone ( ) ;
90-
91- Settings :: builder ( )
92- . with_environment_variable ( ENV_VAR_CONSOLE_LOG )
93- . with_default_level ( LevelFilter :: INFO )
94- . file_log_settings_builder ( log_directory, "tracing-rs.json" )
95- . with_rotation_period ( rotation_period)
96- . build ( )
97- } ) )
98- . with_otlp_log_exporter ( (
99- "OTLP_LOG" ,
100- LevelFilter :: DEBUG ,
101- telemetry_arguments. otlp_logs ,
102- ) )
103- . with_otlp_trace_exporter ( (
104- "OTLP_TRACE" ,
105- LevelFilter :: DEBUG ,
106- telemetry_arguments. otlp_traces ,
107- ) )
108- . build ( )
109- . init ( ) ?;
67+ // NOTE (@NickLarsenNZ): Before stackable-telemetry was used:
68+ // - The console log level was set by `ZOOKEEPER_OPERATOR_LOG`, and is now `CONSOLE_LOG` (when using Tracing::pre_configured).
69+ // - The file log level was set by `ZOOKEEPER_OPERATOR_LOG`, and is now set via `FILE_LOG` (when using Tracing::pre_configured).
70+ // - The file log directory was set by `ZOOKEEPER_OPERATOR_LOG_DIRECTORY`, and is now set by `ROLLING_LOGS_DIR` (or via `--rolling-logs <DIRECTORY>`).
71+ let _tracing_guard =
72+ Tracing :: pre_configured ( built_info:: PKG_NAME , telemetry_arguments) . init ( ) ?;
11073
11174 tracing:: info!(
11275 built_info. pkg_version = built_info:: PKG_VERSION ,
0 commit comments