Skip to content

Commit a44b4bc

Browse files
authored
Merge pull request #6 from stackb/module_rename
Module rename
2 parents c61fc20 + 8e4d253 commit a44b4bc

File tree

8 files changed

+43
-48
lines changed

8 files changed

+43
-48
lines changed

MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module(
2-
name = "io_bazel_rules_closure",
2+
name = "stackb_rules_closure",
33
version = "0.0.0",
44
compatibility_level = 1,
55
)
@@ -167,7 +167,7 @@ maven.install(
167167
known_contributing_modules = [
168168
"build_stack_rules_proto",
169169
"grpc-java",
170-
"io_bazel_rules_closure",
170+
"stackb_rules_closure",
171171
"protobuf",
172172
"rules_web_testing_java",
173173
],

README.md

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Notice
22

3-
This is fork of [bazelbuild/io_bazel_rules_closure](https://github.com/bazelbuild/io_bazel_rules_closure) with the following main differences:
3+
This is fork of [bazelbuild/rules_closure](https://github.com/bazelbuild/rules_closure) with the following main differences:
44

5-
- repo name is `@io_bazel_rules_closure` instead of `@rules_closure`.
5+
- repo name is `@stackb_rules_closure` instead of `@rules_closure`.
66
- the `closure/library` has been restored.
77
- missing shims and third-party closure js code has been vendored in `google3/`.
88
- support for protobuf-javascript has been restored.
@@ -11,11 +11,6 @@ This is fork of [bazelbuild/io_bazel_rules_closure](https://github.com/bazelbuil
1111
- bzlmod deps updated
1212
- stricter .bazelrc flags
1313

14-
> Since this fork is closer to the original rules_closure by @jart and needs to
15-
> be distinguished in the BCR, the repo name has been reverted to
16-
> `@io_bazel_rules_closure`. The version numbers and tagging scheme are
17-
> somewhat arbitrary and will try to follow the numbering in the upstream repo.
18-
1914
# Closure Rules for Bazel (αlpha) [![Bazel CI build status](https://badge.buildkite.com/7569410e2a2661076591897283051b6d137f35102167253fed.svg)](https://buildkite.com/bazel/closure-compiler-rules-closure-postsubmit)
2015

2116
JavaScript | Stylesheets | Miscellaneous
@@ -82,7 +77,7 @@ First you must [install Bazel].
8277
Then you add the following to your MODULE.bazel file:
8378

8479
```bzl
85-
bazel_dep(name = "io_bazel_rules_closure", version = "0.15.0")
80+
bazel_dep(name = "stackb_rules_closure", version = "0.15.0")
8681
```
8782
The root module has to declare the same override for rules_webtesting,
8883
rules_scala, and google_bazel_common temporarily until they are registered
@@ -95,9 +90,9 @@ for that matter; they will be fetched automatically by Bazel.
9590

9691
Please see the test directories within this project for concrete examples of usage:
9792

98-
- [//closure/testing/test](https://github.com/bazelbuild/io_bazel_rules_closure/tree/master/closure/testing/test)
99-
- [//closure/compiler/test](https://github.com/bazelbuild/io_bazel_rules_closure/tree/master/closure/compiler/test)
100-
- [//closure/stylesheets/test](https://github.com/bazelbuild/io_bazel_rules_closure/tree/master/closure/stylesheets/test)
93+
- [//closure/testing/test](https://github.com/stackb/stackb_rules_closure/tree/master/closure/testing/test)
94+
- [//closure/compiler/test](https://github.com/stackb/stackb_rules_closure/tree/master/closure/compiler/test)
95+
- [//closure/stylesheets/test](https://github.com/stackb/stackb_rules_closure/tree/master/closure/stylesheets/test)
10196

10297

10398
# Reference
@@ -319,7 +314,7 @@ This rule can be referenced as though it were the following:
319314
- **defs:** (List of strings; optional) Specifies additional flags to be passed
320315
to the Closure Compiler, e.g. `"--hide_warnings_for=some/path/"`. To see what
321316
flags are available, run:
322-
`bazel run @io_bazel_rules_closure//third_party/java/jscomp:main -- --help`
317+
`bazel run @stackb_rules_closure//third_party/java/jscomp:main -- --help`
323318

324319
### Support for AngularJS
325320

@@ -441,17 +436,17 @@ This rule can be referenced as though it were the following:
441436
`<script>` tag based on a depth-first preordering.
442437

443438
- **html:** (Label; optional; default is
444-
`"@io_bazel_rules_closure//closure/testing:empty.html"`) HTML file containing
439+
`"@stackb_rules_closure//closure/testing:empty.html"`) HTML file containing
445440
DOM structure of virtual web page *before* `<script>` tags are automatically
446441
inserted. Do not include a doctype in this file.
447442

448443
- **harness:** (Label; required; default is
449-
`"@io_bazel_rules_closure//closure/testing:phantomjs_harness"`) JS binary or
444+
`"@stackb_rules_closure//closure/testing:phantomjs_harness"`) JS binary or
450445
library exporting a single source file, to be used as the PhantomJS outer
451446
script.
452447

453448
- **runner:** (Label; optional; default is
454-
`"@io_bazel_rules_closure//closure/testing:phantomjs_jsunit_runner"`) Same as
449+
`"@stackb_rules_closure//closure/testing:phantomjs_jsunit_runner"`) Same as
455450
`deps` but guaranteed to be loaded inside the virtual web page last. This
456451
should run whatever tests got loaded by `deps` and then invoke `callPhantom`
457452
to report the result to the `harness`.
@@ -632,7 +627,7 @@ This rule can be referenced as though it were the following:
632627
[Closure Tools]: https://developers.google.com/closure/
633628
[Closure coding conventions]: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ClosureCodingConvention.java
634629
[ECMASCRIPT6]: http://es6-features.org/
635-
[Exports and Entry Points]: https://github.com/bazelbuild/io_bazel_rules_closure/blob/master/closure/compiler/test/exports_and_entry_points/BUILD
630+
[Exports and Entry Points]: https://github.com/stackb/stackb_rules_closure/blob/master/closure/compiler/test/exports_and_entry_points/BUILD
636631
[Google JavaScript Style Guide]: https://google.github.io/styleguide/jsguide.html
637632
[Google coding conventions]: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/GoogleCodingConvention.java
638633
[Name]: https://docs.bazel.build/versions/master/build-ref.html#name
@@ -642,7 +637,7 @@ This rule can be referenced as though it were the following:
642637
[asserts]: https://github.com/google/closure-library/blob/master/closure/goog/testing/asserts.js#L1308
643638
[base.js]: https://github.com/google/closure-library/blob/master/closure/goog/base.js
644639
[install Bazel]: https://docs.bazel.build/versions/master/install.html
645-
[blockers]: https://github.com/bazelbuild/io_bazel_rules_closure/labels/launch%20blocker
640+
[blockers]: https://github.com/stackb/stackb_rules_closure/labels/launch%20blocker
646641
[closure_css_binary]: #closure_css_binary
647642
[closure_css_library]: #closure_css_library
648643
[closure_grpc_web_library]: https://github.com/grpc/grpc-web/blob/9b7b2d5411c486aa646ba2491cfd894d5352775b/bazel/closure_grpc_web_library.bzl#L149
@@ -654,7 +649,7 @@ This rule can be referenced as though it were the following:
654649
[css-sourcemap]: https://developer.chrome.com/devtools/docs/css-preprocessors
655650
[dependency]: https://docs.bazel.build/versions/master/build-ref.html#dependencies
656651
[filegroup]: https://docs.bazel.build/versions/master/be/general.html#filegroup
657-
[idom-example]: https://github.com/bazelbuild/io_bazel_rules_closure/blob/80d493d5ffc3099372929a8cd4a301da72e1b43f/closure/templates/test/greeter_idom.js
652+
[idom-example]: https://github.com/stackb/stackb_rules_closure/blob/80d493d5ffc3099372929a8cd4a301da72e1b43f/closure/templates/test/greeter_idom.js
658653
[java_library.exports]: https://docs.bazel.build/versions/master/be/java.html#java_library.exports
659654
[java_library]: https://docs.bazel.build/versions/master/be/java.html#java_library
660655
[jquery]: http://jquery.com/

closure/compiler/test/goog_es6_interop/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ closure_js_library(
3939
"person_factory.js",
4040
],
4141
# TODO(yannic): Remove this suppression when
42-
# `bazelbuild/io_bazel_rules_closure#436` is fixed.
42+
# `stackb/stackb_rules_closure#436` is fixed.
4343
suppress = ["moduleLoad"],
4444
deps = [
4545
":person",

closure/goog/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This file is a open-sourced version of internal BUILD file for closure base.
22
# They are too different to attempt a copybara transform between them.
3-
# This file is used in the closure-library repo by external Bazel users (via io_bazel_rules_closure)
3+
# This file is used in the closure-library repo by external Bazel users (via stackb_rules_closure)
44

55
load("//closure/compiler:closure_base_js_library.bzl", "closure_base_js_library")
66

closure/protobuf/defs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def closure_jspb_library(**kwargs):
1616
]
1717

1818
deps = kwargs.pop("deps", [])
19-
deps.append("@io_bazel_rules_closure//closure/protobuf:jspb")
19+
deps.append("@stackb_rules_closure//closure/protobuf:jspb")
2020

2121
closure_js_library(
2222
deps = deps,

closure/templates/closure_js_template_library.bzl

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -128,29 +128,29 @@ def closure_js_template_library(
128128
)
129129

130130
deps = deps + [
131-
"@io_bazel_rules_closure//closure/goog/array",
132-
"@io_bazel_rules_closure//closure/goog/asserts",
133-
"@io_bazel_rules_closure//closure/goog/debug",
134-
"@io_bazel_rules_closure//closure/goog/format",
135-
"@io_bazel_rules_closure//closure/goog/html:safehtml",
136-
"@io_bazel_rules_closure//closure/goog/html:safescript",
137-
"@io_bazel_rules_closure//closure/goog/html:safestyle",
138-
"@io_bazel_rules_closure//closure/goog/html:safestylesheet",
139-
"@io_bazel_rules_closure//closure/goog/html:safeurl",
140-
"@io_bazel_rules_closure//closure/goog/html:trustedresourceurl",
141-
"@io_bazel_rules_closure//closure/goog/html:uncheckedconversions",
142-
"@io_bazel_rules_closure//closure/goog/i18n:bidi",
143-
"@io_bazel_rules_closure//closure/goog/i18n:bidiformatter",
144-
"@io_bazel_rules_closure//closure/goog/i18n:numberformat",
145-
"@io_bazel_rules_closure//closure/goog/object",
146-
"@io_bazel_rules_closure//closure/goog/soy",
147-
"@io_bazel_rules_closure//closure/goog/soy:data",
148-
"@io_bazel_rules_closure//closure/goog/soy:renderer",
149-
"@io_bazel_rules_closure//closure/goog/string",
150-
"@io_bazel_rules_closure//closure/goog/string:const",
151-
"@io_bazel_rules_closure//closure/goog/uri",
152-
"@io_bazel_rules_closure//closure/templates:soy_jssrc",
153-
"@io_bazel_rules_closure//google3/javascript/xid",
131+
"@stackb_rules_closure//closure/goog/array",
132+
"@stackb_rules_closure//closure/goog/asserts",
133+
"@stackb_rules_closure//closure/goog/debug",
134+
"@stackb_rules_closure//closure/goog/format",
135+
"@stackb_rules_closure//closure/goog/html:safehtml",
136+
"@stackb_rules_closure//closure/goog/html:safescript",
137+
"@stackb_rules_closure//closure/goog/html:safestyle",
138+
"@stackb_rules_closure//closure/goog/html:safestylesheet",
139+
"@stackb_rules_closure//closure/goog/html:safeurl",
140+
"@stackb_rules_closure//closure/goog/html:trustedresourceurl",
141+
"@stackb_rules_closure//closure/goog/html:uncheckedconversions",
142+
"@stackb_rules_closure//closure/goog/i18n:bidi",
143+
"@stackb_rules_closure//closure/goog/i18n:bidiformatter",
144+
"@stackb_rules_closure//closure/goog/i18n:numberformat",
145+
"@stackb_rules_closure//closure/goog/object",
146+
"@stackb_rules_closure//closure/goog/soy",
147+
"@stackb_rules_closure//closure/goog/soy:data",
148+
"@stackb_rules_closure//closure/goog/soy:renderer",
149+
"@stackb_rules_closure//closure/goog/string",
150+
"@stackb_rules_closure//closure/goog/string:const",
151+
"@stackb_rules_closure//closure/goog/uri",
152+
"@stackb_rules_closure//closure/templates:soy_jssrc",
153+
"@stackb_rules_closure//google3/javascript/xid",
154154
]
155155

156156
closure_js_library(

closure/webfiles/web_library_external.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def _web_library_external(ctx):
2323
lines.append("")
2424
lines.append("licenses(%s)" % repr(ctx.attr.licenses))
2525
lines.append("")
26-
lines.append("load(\"@io_bazel_rules_closure//closure:" +
26+
lines.append("load(\"@stackb_rules_closure//closure:" +
2727
"defs.bzl\", \"web_library\")")
2828
lines.append("")
2929
lines.append("web_library(")

third_party/phantomjs/phantomjs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ source "${RUNFILES_DIR:-/dev/null}/$f" 2>/dev/null || \
3131
# --- end runfiles.bash initialization v3 ---
3232

3333

34-
RUNFILES="$(rlocation io_bazel_rules_closure/.)"
34+
RUNFILES="$(rlocation stackb_rules_closure/.)"
3535

3636
export LD_LIBRARY_PATH="${RUNFILES}/third_party/fontconfig/k8:${LD_LIBRARY_PATH:-}"
3737
export LD_LIBRARY_PATH="${RUNFILES}/third_party/freetype/k8:${LD_LIBRARY_PATH}"

0 commit comments

Comments
 (0)