Skip to content

Commit 488afdc

Browse files
committed
refactor: add logger
1 parent d1cb79a commit 488afdc

File tree

16 files changed

+112
-49
lines changed

16 files changed

+112
-49
lines changed

eslint.config.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ export default [
1313
"packages/*/dist/**",
1414
"packages/app/.nuxt/**",
1515
"packages/cli/dist/**",
16+
"playgrounds/**",
17+
"templates/**",
1618
],
1719
},
1820
// JavaScript and TypeScript files
@@ -37,7 +39,7 @@ export default [
3739
},
3840
rules: {
3941
// Basic rules
40-
"no-console": "off",
42+
"no-console": "warn",
4143
"no-debugger": "warn",
4244
"no-unused-vars": [
4345
"warn",
@@ -110,7 +112,7 @@ export default [
110112
"vue/no-v-html": "off",
111113

112114
// Basic rules
113-
"no-console": "off",
115+
"no-console": "warn",
114116
"no-debugger": "warn",
115117
"prefer-const": "error",
116118

packages/app/app/components/RepoSearch.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
<script lang="ts" setup>
2+
import { createLogger } from "@pkg-pr-new/utils";
23
import type { RepoNode } from "../../server/utils/types";
4+
5+
const logger = createLogger();
36
const search = useSessionStorage("search", "");
47
const searchResults = ref<RepoNode[]>([]);
58
const isLoading = ref(false);
@@ -32,7 +35,7 @@ watch(
3235
}
3336
} catch (err: any) {
3437
if (err.name !== "AbortError") {
35-
console.error(err);
38+
logger.error(err);
3639
}
3740
} finally {
3841
if (activeController === controller) {

packages/app/e2e.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import ezSpawn from "@jsdevtools/ez-spawn";
44
import { simulation } from "@simulacrum/github-api-simulator";
55
import { afterAll, beforeAll, describe, expect, it } from "vitest";
66
import { unstable_dev } from "wrangler";
7+
import { createLogger } from "@pkg-pr-new/utils";
78
import prPullRequestSynchronizeFixture from "./fixtures/pr.pull_request.json";
89
import prWorkflowRunRequestedFixture from "./fixtures/pr.workflow_run.requested.json";
910
import pushWorkflowRunInProgressFixture from "./fixtures/workflow_run.in_progress.json";
@@ -12,6 +13,7 @@ let server: Awaited<ReturnType<ReturnType<typeof simulation>["listen"]>>;
1213
let workerUrl: string;
1314

1415
let worker: UnstableDevWorker;
16+
const logger = createLogger();
1517
beforeAll(async () => {
1618
const app = simulation({
1719
initialState: {
@@ -122,9 +124,9 @@ describe.sequential.each([
122124
shell: true,
123125
},
124126
);
125-
console.log(process.stdout);
127+
logger.info(process.stdout);
126128
} catch (error) {
127-
console.log(error);
129+
logger.error(error);
128130
}
129131
}, 10_000);
130132

packages/app/script/generate-dev-vars.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import crypto from "node:crypto";
22
import fs from "node:fs/promises";
33
import path from "node:path";
4+
import { createLogger } from "@pkg-pr-new/utils";
5+
6+
const logger = createLogger();
47

58
async function generateDevVars() {
69
const filePath = path.join(
@@ -63,7 +66,7 @@ async function generateDevVars() {
6366
// Write to .dev.vars file
6467
await fs.writeFile(filePath, envContent, "utf8");
6568

66-
console.log("Updated .dev.vars file successfully!");
69+
logger.info("Updated .dev.vars file successfully!");
6770
}
6871

69-
generateDevVars().catch(console.error);
72+
generateDevVars().catch(logger.error);

packages/app/script/update-webhook-url.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import process from "node:process";
22
import { config } from "dotenv";
3+
import { createLogger } from "@pkg-pr-new/utils";
34
import { createSigner } from "fast-jwt";
45
import { Octokit } from "octokit";
56

7+
const logger = createLogger();
8+
69
config({ path: ".dev.vars" });
710

811
const nitroSigner = createSigner({
@@ -31,7 +34,7 @@ const {
3134
data: { url },
3235
} = await octokit.request("GET /app/hook/config");
3336

34-
console.log(`current webhook url: ${url}`);
37+
logger.info(`current webhook url: ${url}`);
3538

3639
const newUrl = new URL(
3740
"/webhook",
@@ -44,4 +47,4 @@ const result = await octokit.request({
4447
data: { url: newUrl.href },
4548
});
4649

47-
console.log(`webhook url is ${result.data.url} now!`);
50+
logger.info(`webhook url is ${result.data.url} now!`);

packages/app/server/api/repo/commits.get.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
import { createLogger } from "@pkg-pr-new/utils";
12
import { z } from "zod";
23

4+
const logger = createLogger();
5+
36
const querySchema = z.object({
47
owner: z.string(),
58
repo: z.string(),
@@ -95,7 +98,7 @@ export default defineEventHandler(async (event) => {
9598
: null,
9699
};
97100
} catch (error) {
98-
console.warn(
101+
logger.warn(
99102
`Could not fetch check runs for commit ${commit.sha}:`,
100103
error,
101104
);
@@ -132,7 +135,7 @@ export default defineEventHandler(async (event) => {
132135
},
133136
};
134137
} catch (error) {
135-
console.error("Error fetching repository commits:", error);
138+
logger.error("Error fetching repository commits:", error);
136139

137140
return {
138141
id: "error",

packages/app/server/api/repo/index.get.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import type { H3Event } from "h3";
2+
import { createLogger } from "@pkg-pr-new/utils";
23
import { z } from "zod";
34

5+
const logger = createLogger();
6+
47
const querySchema = z.object({
58
owner: z.string(),
69
repo: z.string(),
@@ -32,7 +35,7 @@ const getRepoInfo = defineCachedFunction(
3235
releaseCount,
3336
};
3437
} catch (error) {
35-
console.error(
38+
logger.error(
3639
`Error fetching repository info for ${owner}/${repo}:`,
3740
error,
3841
);
@@ -53,7 +56,7 @@ export default defineEventHandler(async (event) => {
5356
);
5457
return getRepoInfo(query.owner, query.repo, event);
5558
} catch (error) {
56-
console.error("Error in repo info endpoint:", error);
59+
logger.error("Error in repo info endpoint:", error);
5760
return {
5861
error: true,
5962
message: (error as Error).message,
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
1+
import { createLogger } from "@pkg-pr-new/utils";
2+
3+
const logger = createLogger();
4+
15
// This plugin ensures runtime config is properly initialized early in the request lifecycle
26
export default defineNitroPlugin((nitro) => {
37
nitro.hooks.hook("request", async (event) => {
48
try {
59
// Pre-load the configuration to ensure it's initialized
610
const config = useRuntimeConfig(event);
7-
console.log(
11+
logger.info(
812
"Runtime config initialized successfully:",
913
Object.keys(config),
1014
);
1115
} catch (error) {
12-
console.error("Failed to initialize runtime config:", error);
16+
logger.error("Failed to initialize runtime config:", error);
1317
}
1418
});
1519
});
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1+
import { createLogger } from "@pkg-pr-new/utils";
2+
3+
const logger = createLogger();
4+
15
export default defineNitroPlugin((nitro) => {
26
nitro.hooks.hook("error", async (error, { event }) => {
3-
console.error(`${event?.path} Application error:`, error);
7+
logger.error(`${event?.path} Application error:`, error);
48
});
59
});

packages/app/server/routes/check.post.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
import { createLogger } from "@pkg-pr-new/utils";
2+
3+
const logger = createLogger();
4+
15
export default eventHandler(async (event) => {
26
try {
37
const data = await readRawBody(event);
@@ -43,7 +47,7 @@ export default eventHandler(async (event) => {
4347
}
4448
return { sha: workflowData.sha };
4549
} catch (error: unknown) {
46-
console.error("Check route error:", error);
50+
logger.error("Check route error:", error);
4751

4852
if (error && typeof error === "object" && "statusCode" in error) {
4953
throw error;

0 commit comments

Comments
 (0)