update

Author: AmirSa12

.eslintrc

@@ -1,3 +1,34 @@
 {
-  "extends": ["eslint-config-unjs"]
+  "extends": ["eslint-config-unjs"],
+  "rules": {
+    "unicorn/no-null": "off",
+    "require-await": "error",
+    "unicorn/filename-case": "off",
+    "unicorn/no-process-exit": "error",
+    "unicorn/prefer-ternary": "error",
+    "unicorn/prefer-top-level-await": "off",
+    "no-useless-constructor": "error",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+      },
+    ],
+    "@typescript-eslint/no-namespace": "error",
+    "camelcase": "off",
+    "unicorn/prefer-code-point": "error",
+    "unicorn/prefer-string-slice": "off",
+    "unicorn/prefer-at": "off",
+    "unicorn/explicit-length-check": "off",
+    "no-empty": [
+      "error",
+      {
+        "allowEmptyCatch": true,
+      },
+    ],
+    "prefer-const": "error",
+    "unicorn/no-empty-file": "error",
+    "@typescript-eslint/no-non-null-assertion": "off",
+  },
 }

e2e/publish.test.mts

@@ -1,7 +1,8 @@
-import { exec } from "child_process";
-import { platform } from "os";
-import wp from "wait-port";
+/* eslint-disable unicorn/no-process-exit */
+import { exec } from "node:child_process";
+import { platform } from "node:os";
 import assert from "node:assert";
+import wp from "wait-port";
 import ezSpawn from "@jsdevtools/ez-spawn";
 import pushWorkflowRunInProgressFixture from "./fixtures/workflow_run.in_progress.json" with { type: "json" };
 import prWorkflowRunRequestedFixture from "./fixtures/pr.workflow_run.requested.json" with { type: "json" };
@@ -246,8 +247,8 @@ async function killPort() {
         killSignal: "SIGINT",
       });
     }
-  } catch (e) {
-    console.error(e);
+  } catch (error) {
+    console.error(error);
     c.abort();
     process.exit(1);
   } finally {

packages/backend/objects.ts

@@ -1,10 +1,3 @@
-import { DurableObjectState } from "@cloudflare/workers-types";
-import type { Env } from "nitro-cloudflare-dev";
-
 export class Workflows {
-  constructor(state: DurableObjectState, env: Env) {}
-
-  async fetch(request: Request) {
-    return new Response("Hello World");
-  }
+  fetch() { return new Response("Hello World"); }
 }

packages/backend/script/ci.ts

@@ -1,9 +1,8 @@
-import fs from "fs/promises";
+import fs from "node:fs/promises";
 if (process.env.CI) {
-  const content = Object.entries(process.env)
+  const content = [...Object.entries(process.env)
     .filter(([k]) => k.startsWith("NITRO"))
-    .map(([k, v]) => `${k}="${v}"`)
-    .concat(["NITRO_TEST=true", "GITHUB_TOKEN=" + process.env.GITHUB_TOKEN!])
+    .map(([k, v]) => `${k}="${v}"`), "NITRO_TEST=true", "GITHUB_TOKEN=" + process.env.GITHUB_TOKEN!]
     .join("\n");
   await fs.writeFile(".dev.vars", content);
 }

packages/backend/script/octokit.ts

@@ -1,5 +1,5 @@
-import esbuild from "esbuild";
 import { fileURLToPath } from "node:url";
+import esbuild from "esbuild";
 import { polyfillNode } from "esbuild-plugin-polyfill-node";
 
 await esbuild.build({

packages/backend/script/update-webhook-url.ts

@@ -26,7 +26,7 @@ const octokit = new Octokit({
   auth: jwtToken,
 });
 
-let {
+const {
   data: { url },
 } = await octokit.request("GET /app/hook/config");
 

packages/backend/server/middleware/cors.ts

@@ -1,5 +1,5 @@
 export default defineEventHandler((event) => {
   if (handleCors(event, {})) {
-    return;
+    console.log('CORS was successfully handled');
   }
 });

packages/backend/server/octokit.ts

@@ -27,6 +27,12 @@ import { createAppAuth } from "@octokit/auth-app";
 import { OAuthApp } from "@octokit/oauth-app";
 import { Webhooks, type EmitterWebhookEvent } from "@octokit/webhooks";
 
+import type { Octokit } from "@octokit/core";
+import { createUnauthenticatedAuth } from "@octokit/auth-unauthenticated";
+
+// https://github.com/octokit/app.js/blob/main/src/types.ts
+import type { Endpoints } from "@octokit/types";
+
 type Constructor<T> = new (...args: any[]) => T;
 
 type OctokitType<TOptions extends Options> =
@@ -64,6 +70,7 @@ export class App<TOptions extends Options = Options> {
     clientType: "github-app";
     Octokit: OctokitClassType<TOptions>;
   }>;
+
   log: {
     debug: (message: string, additionalInfo?: object) => void;
     info: (message: string, additionalInfo?: object) => void;
@@ -136,9 +143,6 @@ export class App<TOptions extends Options = Options> {
   }
 }
 
-import type { Octokit } from "@octokit/core";
-import { createUnauthenticatedAuth } from "@octokit/auth-unauthenticated";
-
 export function webhooks(
   appOctokit: Octokit,
   options: Required<Options>["webhooks"],
@@ -173,12 +177,12 @@ export function webhooks(
           return new auth.octokit.constructor({
             ...auth.octokitOptions,
             authStrategy: createAppAuth,
-            ...{
+            
               auth: {
                 ...auth,
                 installationId,
-              },
-            },
+              }
+            ,
           });
         },
       })) as Octokit;
@@ -201,9 +205,6 @@ export function webhooks(
   });
 }
 
-// https://github.com/octokit/app.js/blob/main/src/types.ts
-import type { Endpoints } from "@octokit/types";
-
 export type Options = {
   appId?: number | string;
   privateKey?: string;

packages/backend/server/plugins/error.ts

@@ -1,5 +1,5 @@
 export default defineNitroPlugin((nitro) => {
-  nitro.hooks.hook("error", async (error, { event }) => {
+  nitro.hooks.hook("error", (error, { event }) => {
     console.error(`${event?.path} Application error:`, error);
   });
 });

packages/backend/server/routes/[owner]/[repo]/[npmOrg]/[packageAndRefOrSha].get.ts

@@ -5,7 +5,7 @@ type Params = Omit<WorkflowData, "sha" | "isPullRequest" | "ref"> & {
   packageAndRefOrSha: string;
 };
 
-export default eventHandler(async (event) => {
+export default eventHandler((event) => {
   const params = getRouterParams(event) as Params;
   const [noScopePackageName, refOrSha] = params.packageAndRefOrSha.split("@");
   const packageName = params.npmOrg + "/" + noScopePackageName;