chore: proper error handling in stale.post.ts

Author: Aslemammad

packages/app/server/routes/rm/stale.post.ts

@@ -1,29 +1,63 @@
 import type { H3Event } from "h3";
 
 export default eventHandler(async (event) => {
-  const rmStaleKeyHeader = getHeader(event, "sb-rm-stale-key");
-  const signal = toWebRequest(event).signal;
-  const { rmStaleKey } = useRuntimeConfig(event);
+  try {
+    const rmStaleKeyHeader = getHeader(event, "sb-rm-stale-key");
+    const signal = toWebRequest(event).signal;
+    const { rmStaleKey } = useRuntimeConfig(event);
 
-  if (rmStaleKeyHeader !== rmStaleKey) {
-    throw createError({
-      status: 403,
-    });
-  }
+    if (rmStaleKeyHeader !== rmStaleKey) {
+      throw createError({
+        status: 403,
+      });
+    }
 
-  const { bucket, cursor, remove } = await readBody<{ bucket: 'packages' | 'templates'; cursor: string | null; remove: boolean }>(event);
+    const { bucket, cursor, remove } = await readBody<{ bucket: 'packages' | 'templates'; cursor: string | null; remove: boolean }>(event);
 
-  const result = await iterateAndDelete(event, signal, {
-    prefix: bucket === 'packages' ? usePackagesBucket.base : useTemplatesBucket.base,
-    limit: 1000,
-    cursor: cursor || undefined,
-  }, remove);
+    try {
+      const result = await iterateAndDelete(event, signal, {
+        prefix: bucket === 'packages' ? usePackagesBucket.base : useTemplatesBucket.base,
+        limit: 1000,
+        cursor: cursor || undefined,
+      }, remove);
 
-  setResponseHeader(event, "Content-Type", "application/json");
+      setResponseHeader(event, "Content-Type", "application/json");
 
-  return {
-    result,
-  };
+      return {
+        result,
+      };
+    } catch (err: any) {
+      // Log error with context
+      console.error('[rm/stale] Error in iterateAndDelete', {
+        bucket,
+        cursor,
+        remove,
+        error: err && err.stack ? err.stack : err,
+      });
+      throw createError({
+        status: 500,
+        statusMessage: 'Internal Server Error',
+        data: {
+          message: err && err.message ? err.message : String(err),
+          stack: err && err.stack ? err.stack : undefined,
+          bucket,
+          cursor,
+          remove,
+        },
+      });
+    }
+  } catch (outerErr: any) {
+    // Log any error at the outer handler level
+    console.error('[rm/stale] Handler error', outerErr && outerErr.stack ? outerErr.stack : outerErr);
+    throw createError({
+      status: 500,
+      statusMessage: 'Internal Server Error',
+      data: {
+        message: outerErr && outerErr.message ? outerErr.message : String(outerErr),
+        stack: outerErr && outerErr.stack ? outerErr.stack : undefined,
+      },
+    });
+  }
 });
 
 // Helper for concurrency limiting