Skip to content

Commit d0037da

Browse files
committed
Use better variable names
1 parent 5067efa commit d0037da

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,8 @@ As noted in [#140](https://github.com/stackblitz-labs/pkg.pr.new/issues/140), wo
303303

304304
After `pkg-pr-new publish` runs successfully, some outputs are available.
305305

306-
- `tag`: The short SHA used. (e.g. `a832a55`)
307-
- `packages`: Space-separated URLs of published packages.
306+
- `sha`: The short SHA used. (E.g. `a832a55`)
307+
- `urls`: Space-separated URLs of published packages.
308308

309309
This is useful for using published packages in other subsequent jobs immediately after publishing. (E.g. E2E tests)
310310

@@ -316,8 +316,8 @@ jobs:
316316
publish:
317317
runs-on: ubuntu-latest
318318
outputs:
319-
tag: ${{ steps.publish.outputs.tag }}
320-
packages: ${{ steps.publish.outputs.packages }}
319+
sha: ${{ steps.publish.outputs.sha }}
320+
urls: ${{ steps.publish.outputs.urls }}
321321
steps:
322322
- name: Checkout code
323323
uses: actions/checkout@v4
@@ -355,7 +355,7 @@ jobs:
355355
run: pnpm install
356356
357357
- name: Install published package
358-
run: pnpm add ${{ needs.publish.outputs.packages }}
358+
run: pnpm add ${{ needs.publish.outputs.urls }}
359359
360360
- name: Run e2e test cases
361361
run: # ...

packages/cli/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -535,10 +535,10 @@ const main = defineCommand({
535535
console.warn(`metadata written to ${jsonFilePath}`);
536536
}
537537

538-
await fs.appendFile(GITHUB_OUTPUT, `tag=${formattedSha}\n`, "utf8");
538+
await fs.appendFile(GITHUB_OUTPUT, `sha=${formattedSha}\n`, "utf8");
539539
await fs.appendFile(
540540
GITHUB_OUTPUT,
541-
`packages=${outputMetadata.packages.map((pkg) => pkg.url).join(" ")}\n`,
541+
`urls=${outputMetadata.packages.map((pkg) => pkg.url).join(" ")}\n`,
542542
"utf8",
543543
);
544544
},

0 commit comments

Comments
 (0)