fix: unset sub flags before propagate in trigger function

Author: johnsoncodehk

src/index.ts

@@ -193,13 +193,15 @@ export function trigger(fn: () => void) {
 		fn();
 	} finally {
 		activeSub = prevSub;
-		while (sub.deps !== undefined) {
-			const link = sub.deps;
+		let link = sub.deps;
+		while (link !== undefined) {
 			const dep = link.dep;
-			unlink(link, sub);
-			if (dep.subs !== undefined) {
-				propagate(dep.subs);
-				shallowPropagate(dep.subs);
+			link = unlink(link, sub);
+			const subs = dep.subs;
+			if (subs !== undefined) {
+				sub.flags = ReactiveFlags.None;
+				propagate(subs);
+				shallowPropagate(subs);
 			}
 		}
 		if (!batchDepth) {

tests/trigger.spec.ts

@@ -48,3 +48,17 @@ test('should trigger effect once', () => {
 	});
 	expect(triggers).toBe(2);
 });
+
+test('should not notify the trigger function sub', () => {
+	const src1 = signal<number[]>([]);
+	const src2 = computed(() => src1());
+
+	effect(() => {
+		src1();
+		src2();
+	});
+	trigger(() => {
+		src1();
+		src2();
+	});
+});