refactor(system): compatible with consumers that do not support inner effects

Author: johnsoncodehk

src/effect.ts

@@ -7,7 +7,7 @@ export function effect(fn: () => void): Effect<void> {
 	return e;
 }
 
-export class Effect<T = any> implements IEffect {
+export class Effect<T = any> implements IEffect, Dependency {
 	nextNotify: IEffect | undefined = undefined;
 
 	// Dependency

src/system.ts

@@ -1,4 +1,4 @@
-export interface IEffect extends Dependency, Subscriber {
+export interface IEffect extends Subscriber {
 	nextNotify: IEffect | undefined;
 	notify(): void;
 }
@@ -21,7 +21,7 @@ export interface Subscriber {
 }
 
 export interface Link {
-	dep: Dependency | IComputed | IEffect;
+	dep: Dependency | IComputed | (Dependency & IEffect);
 	sub: Subscriber | IComputed | IEffect;
 	trackId: number;
 	// Also used as prev update
@@ -282,7 +282,7 @@ export namespace Subscriber {
 
 	const system = System;
 
-	export function resolveMaybeDirty(sub: IComputed | IEffect, depth = 0): void {
+	export function resolveMaybeDirty(sub: IComputed | (IEffect & Dependency), depth = 0): void {
 		let link = sub.deps;
 
 		while (link !== undefined) {
@@ -313,7 +313,7 @@ export namespace Subscriber {
 		}
 	}
 
-	export function resolveMaybeDirtyNonRecursive(sub: IComputed | IEffect): void {
+	export function resolveMaybeDirtyNonRecursive(sub: IComputed | (IEffect & Dependency)): void {
 		let link = sub.deps;
 		let remaining = 0;
 
@@ -340,7 +340,7 @@ export namespace Subscriber {
 								const prevLink = subSubs.prevSub!;
 								(sub as IComputed).update();
 								subSubs.prevSub = undefined;
-								sub = prevLink.sub as IComputed | IEffect;
+								sub = prevLink.sub as IComputed | (IEffect & Dependency);
 								link = prevLink.nextDep;
 								remaining--;
 								continue;
@@ -363,7 +363,7 @@ export namespace Subscriber {
 					const subSubs = sub.subs!;
 					const prevLink = subSubs.prevSub!;
 					subSubs.prevSub = undefined;
-					sub = prevLink.sub as IComputed | IEffect;
+					sub = prevLink.sub as IComputed | (IEffect & Dependency);
 					link = prevLink.nextDep;
 					remaining--;
 					continue;
@@ -375,7 +375,7 @@ export namespace Subscriber {
 				const subSubs = sub.subs!;
 				const prevLink = subSubs.prevSub!;
 				subSubs.prevSub = undefined;
-				sub = prevLink.sub as IComputed | IEffect;
+				sub = prevLink.sub as IComputed | (IEffect & Dependency);
 				link = prevLink.nextDep;
 				remaining--;
 				continue;