Repairs from nightly clippy

Author: jpgrayson

src/cmd/email/format.rs

@@ -61,7 +61,7 @@ pub(super) fn command() -> clap::Command<'static> {
                 .multiple_values(true)
                 .value_parser(clap::value_parser!(patchrange::Specification))
                 .conflicts_with("all")
-                .required_unless_present_any(&["all"]),
+                .required_unless_present_any(["all"]),
         )
         .arg(argset::branch_arg())
         .arg(

src/cmd/email/send.rs

@@ -66,7 +66,7 @@ pub(super) fn command() -> clap::Command<'static> {
                 .multiple_values(true)
                 .value_parser(clap::builder::NonEmptyStringValueParser::new())
                 .conflicts_with_all(&["all", "dump-aliases"])
-                .required_unless_present_any(&["all", "dump-aliases"]),
+                .required_unless_present_any(["all", "dump-aliases"]),
         )
         .arg(argset::branch_arg())
         .arg(

src/cmd/import.rs

@@ -287,7 +287,7 @@ fn import_url(stack: Stack, matches: &clap::ArgMatches) -> Result<()> {
 
 #[cfg(feature = "import-compressed")]
 fn import_tgz_series(stack: Stack, matches: &clap::ArgMatches, source_path: &Path) -> Result<()> {
-    let source_file = std::fs::File::open(&source_path)?;
+    let source_file = std::fs::File::open(source_path)?;
     let mut archive = tar::Archive::new(flate2::read::GzDecoder::new(source_file));
     let temp_dir = tempfile::tempdir()?;
     archive.unpack(temp_dir.path())?;
@@ -297,7 +297,7 @@ fn import_tgz_series(stack: Stack, matches: &clap::ArgMatches, source_path: &Pat
 
 #[cfg(feature = "import-compressed")]
 fn import_tbz2_series(stack: Stack, matches: &clap::ArgMatches, source_path: &Path) -> Result<()> {
-    let source_file = std::fs::File::open(&source_path)?;
+    let source_file = std::fs::File::open(source_path)?;
     let mut archive = tar::Archive::new(bzip2::read::BzDecoder::new(source_file));
     let temp_dir = tempfile::tempdir()?;
     archive.unpack(temp_dir.path())?;
@@ -307,7 +307,7 @@ fn import_tbz2_series(stack: Stack, matches: &clap::ArgMatches, source_path: &Pa
 
 #[cfg(feature = "import-compressed")]
 fn import_tar_series(stack: Stack, matches: &clap::ArgMatches, source_path: &Path) -> Result<()> {
-    let source_file = std::fs::File::open(&source_path)?;
+    let source_file = std::fs::File::open(source_path)?;
     let mut archive = tar::Archive::new(source_file);
     let temp_dir = tempfile::tempdir()?;
     archive.unpack(temp_dir.path())?;

src/cmd/rebase.rs

@@ -304,7 +304,7 @@ fn interactive_pushback(
                 let dummy_edit_command = clap::Command::new("dummy-edit");
                 let dummy_edit_command = patchedit::add_args(dummy_edit_command, false, false);
                 let edit_matches = dummy_edit_command
-                    .try_get_matches_from(&["dummy-edit", "--edit", "--diff"])
+                    .try_get_matches_from(["dummy-edit", "--edit", "--diff"])
                     .expect("dummy command has valid arguments");
                 match patchedit::EditBuilder::default()
                     .original_patchname(Some(patchname))
@@ -369,14 +369,14 @@ fn interactive_pushback(
                 let dummy_squash_command = patchedit::add_args(dummy_squash_command, true, false);
                 let squash_matches = match instruction.action {
                     Action::Squash => {
-                        dummy_squash_command.try_get_matches_from(&["dummy-squash", "--edit"])
+                        dummy_squash_command.try_get_matches_from(["dummy-squash", "--edit"])
                     }
                     Action::Fixup => {
                         let commit = stack.get_patch_commit(target_patchname);
                         let message = commit.message_raw().ok_or_else(|| {
                             anyhow!("Fixup target patch `{target_patchname}` has non-UTF-8 message")
                         })?;
-                        dummy_squash_command.try_get_matches_from(&[
+                        dummy_squash_command.try_get_matches_from([
                             "dummy-squash",
                             "--message",
                             message,

src/commit.rs

@@ -234,7 +234,7 @@ impl<'a> CommitMessage<'a> {
         match self {
             Self::Str(s) => s.as_bytes(),
             Self::String(s) => s.as_bytes(),
-            Self::Raw { bytes, encoding: _ } => *bytes,
+            Self::Raw { bytes, encoding: _ } => bytes,
         }
     }
 }

src/patchedit/mod.rs

@@ -608,7 +608,7 @@ impl<'a, 'repo> EditBuilder<'a, 'repo> {
                     new_tree.id(),
                     <Option<Vec<OsString>>>::None,
                     false,
-                    &["--full-index"],
+                    ["--full-index"],
                 )?
             } else {
                 // This is a special case for `stg new` without the `--refresh` option.
@@ -732,7 +732,7 @@ impl<'a, 'repo> EditBuilder<'a, 'repo> {
                 Err(e) => {
                     let diff = Some(DiffBuffer(diff));
                     let failed_description_path = ".stgit-failed.patch";
-                    let mut stream = BufWriter::new(File::create(&failed_description_path)?);
+                    let mut stream = BufWriter::new(File::create(failed_description_path)?);
                     let failed_patch_description = EditablePatchDescription {
                         patchname,
                         author,

src/templates.rs

@@ -40,7 +40,7 @@ pub(crate) fn get_template(repo: &git2::Repository, name: &str) -> Result<Option
     // /etc/stgit/templates.
 
     for template_path in &template_paths {
-        if let Ok(template_bytes) = std::fs::read(&template_path) {
+        if let Ok(template_bytes) = std::fs::read(template_path) {
             let template = std::str::from_utf8(&template_bytes).map_err(|_| {
                 anyhow!(
                     "Template file `{}` contains non-UTF-8 data",