Inconsistent formatting of external vs internal links

[ekzyis]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Here, I created an external link using this syntax to make the text italic and it worked:

[_How to Win Friends and Influence People_](https://www.goodreads.com/book/show/4865.How_to_Win_Friends_Influence_People)

Here, I used the same syntax for an internal link and it didn't work:

 [_High Risk, Low Reward_](https://stacker.news/items/778491)

I think it's related to external vs internal links. The formatting works as expected if I don't use a stacker.news link.

Screenshots

No response

Steps To Reproduce

Create a stacker.news link with markdown and make the text italic

Expected behavior

Text is italic independent of which link was used

Logs

No response

Device information

No response

Additional context

No response

[Soxasora]

Hi ek! This happens because ItemMentionNode is a decorator node (leaf node), a special node that renders a container and a React component inside of it (in this case we use it for the ItemPopover component), and as such it can't follow Lexical's formatting.

The fix is relatively easy, we're talking about making ItemMentionNode aware of the text format that our MDAST pipeline recognized and apply that format in the decorate() React component.¹

Will address this as soon as I have more time! Thanks!!

Footnotes

1. In a perfect world we would have wanted to make every DecoratorNode aware of Lexical formatting, but this implies meddling with internal Lexical code and a loooooot of code for something so minimal ↩