Skip to content

Commit 3379fe8

Browse files
committed
Fix ansible-tests on 2.16
Add tests/sanity/ignore-2.16.txt (yes, in collections a file per version is required) Instead of installing coverage in test-requirements - adding --requirements arg to ansible-test to install the correct version (bypasses the need to manage exact version in test-requirements.txt )
1 parent fa76f33 commit 3379fe8

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ jobs:
5656
- name: Run ansible-test units
5757
working-directory: ansible_collections/stackhpc/cephadm
5858
run: |
59-
ansible-test units --verbose --docker --coverage
60-
ansible-test coverage xml
61-
ansible-test coverage html
59+
ansible-test units --verbose --docker --coverage --requirements
60+
ansible-test coverage xml --requirements
61+
ansible-test coverage html --requirements
6262
6363
- name: Print coverage report
6464
working-directory: ansible_collections/stackhpc/cephadm

test-requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
ansible>=2.9
22
ansible-lint<7
33
antsibull-changelog
4-
coverage<=6.5.0
54
mock
65
pytest
76
pytest-forked

tests/sanity/ignore-2.16.txt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
plugins/modules/cephadm_pool.py pylint:disallowed-name
2+
plugins/modules/cephadm_crush_rule.py validate-modules:missing-gplv3-license
3+
plugins/modules/cephadm_crush_rule.py validate-modules:parameter-state-invalid-choice
4+
plugins/modules/cephadm_crush_rule.py validate-modules:invalid-documentation
5+
plugins/modules/cephadm_ec_profile.py validate-modules:invalid-documentation
6+
plugins/modules/cephadm_ec_profile.py validate-modules:missing-gplv3-license
7+
plugins/modules/cephadm_key.py validate-modules:invalid-documentation
8+
plugins/modules/cephadm_key.py validate-modules:missing-gplv3-license
9+
plugins/modules/cephadm_key.py validate-modules:parameter-state-invalid-choice
10+
plugins/modules/cephadm_pool.py validate-modules:missing-gplv3-license
11+
plugins/modules/cephadm_pool.py validate-modules:parameter-state-invalid-choice
12+
plugins/modules/cephadm_pool.py validate-modules:invalid-documentation
13+
plugins/modules/cephadm_pool.py validate-modules:doc-default-does-not-match-spec

0 commit comments

Comments
 (0)