lint: Fix os_host_aggregates issues

Author: markgoddard

roles/os_host_aggregates/defaults/main.yml

@@ -1,21 +1,17 @@
 ---
 # Path to a directory in which to create a virtualenv.
 os_host_aggregates_venv:
-
 # Authentication type.
 os_host_aggregates_auth_type:
-
 # Authentication information.
 os_host_aggregates_auth: {}
-
 # Endpoint URL type to fetch from the service catalog. Maybe be one of:
 # public, admin, or internal.
 os_host_aggregates_interface:
-
 # List of nova host aggregates to register. Each item should be a dict containing the
 # following items:
 # - 'name': Name of the host aggregate.
 # - 'availability_zone': Name of the availability zone, optional.
 # - 'hosts': List of hosts to add to the aggregate, optional.
 # - 'metadata': Dict of key/value pairs to set on the aggregate, optional.
-os_host_aggregates: []
+os_host_aggregates: [] # noqa var-naming[no-role-prefix]

roles/os_host_aggregates/meta/main.yml

@@ -1,22 +1,4 @@
 ---
-galaxy_info:
-  role_name: os_host_aggregates
-  author: Pierre Riteau
-  description: >
-    Role to register nova host aggregates in OpenStack
-  company: StackHPC Ltd
-  license: Apache2
-  min_ansible_version: 2.6
-  platforms:
-    - name: EL
-      versions:
-        - 7
-        - 8
-  galaxy_tags:
-    - cloud
-    - nova
-    - openstack
-
 dependencies:
-  - role: stackhpc.os_openstacksdk
+  - role: stackhpc.openstack.os_openstacksdk
     os_openstacksdk_venv: "{{ os_host_aggregates_venv }}"

roles/os_host_aggregates/tasks/host-aggregates.yml

@@ -1,6 +1,6 @@
 ---
 - name: Ensure nova host aggregates exist
-  os_nova_host_aggregate:
+  openstack.cloud.host_aggregate:
     auth_type: "{{ os_host_aggregates_auth_type }}"
     auth: "{{ os_host_aggregates_auth }}"
     cacert: "{{ os_host_aggregates_cacert | default(omit) }}"

roles/os_host_aggregates/tasks/main.yml

@@ -1,8 +1,9 @@
 ---
 - name: Set a fact about the Ansible python interpreter
-  set_fact:
+  ansible.builtin.set_fact:
     old_ansible_python_interpreter: "{{ ansible_python_interpreter | default('/usr/bin/python' + ansible_python.version.major | string) }}"
 
-- import_tasks: host-aggregates.yml
+- name: Import host-aggregates.yml
+  ansible.builtin.import_tasks: host-aggregates.yml
   vars:
     ansible_python_interpreter: "{{ os_host_aggregates_venv ~ '/bin/python' if os_host_aggregates_venv != None else old_ansible_python_interpreter }}"

roles/os_host_aggregates/tests/test.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: all
+- name: Test os_host_aggregates role
+  hosts: all
   connection: local
   roles:
-    - stackhpc.os_host_aggregates
+    - stackhpc.openstack.os_host_aggregates