Skip to content

Commit 41e7c2d

Browse files
committed
Only updating users when there is a change
1 parent d7b764b commit 41e7c2d

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

roles/pulp_user/tasks/main.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,21 @@
5151
when:
5252
- users_get_result.results[user_index].json.count == 1
5353
- pulp_users[user_index].state is not defined or pulp_users[user_index].state != "absent"
54+
- >-
55+
users_get_result.results[user_index].json.results[0].username != pulp_users[user_index].username or
56+
(pulp_users[user_index].first_name is defined and
57+
users_get_result.results[user_index].json.results[0].first_name != pulp_users[user_index].first_name) or
58+
(pulp_users[user_index].last_name is defined and
59+
users_get_result.results[user_index].json.results[0].last_name != pulp_users[user_index].last_name) or
60+
(pulp_users[user_index].email is defined and
61+
users_get_result.results[user_index].json.results[0].email != pulp_users[user_index].email) or
62+
(pulp_users[user_index].is_active is defined and
63+
users_get_result.results[user_index].json.results[0].is_active != pulp_users[user_index].is_active) or
64+
(pulp_users[user_index].is_staff is defined and
65+
users_get_result.results[user_index].json.results[0].is_staff != pulp_users[user_index].is_staff) or
66+
(pulp_users[user_index].groups is defined and
67+
users_get_result.results[user_index].json.results[0].groups | map(attribute='name') | list != pulp_users[user_index].groups) or
68+
pulp_users[user_index].password is defined
5469
5570
- name: Create users
5671
uri:
@@ -74,7 +89,6 @@
7489
index_var: user_index
7590
changed_when: true
7691

77-
# Will always mark as changed even if user is the same as described
7892
- name: Update existing users
7993
uri:
8094
url: "{{ pulp_url }}{{ update_users[user_index].pulp_href }}"

0 commit comments

Comments
 (0)