make all molecule tests configless

Author: sjpb

molecule/README.md

@@ -6,24 +6,23 @@ Test options in "Other" column flow down through table unless changed.
 
 Test   | # Partitions | Groups in partitions?   | Other
 ---    | ---          | ---                     | ---
-test1  | 1            | N                       | 2x compute node, sequential names (default test), config on all nodes
+test1  | 1            | N                       | 2x compute node, sequential names (default test)
 test1b | 1            | N                       | 1x compute node
 test1c | 1            | N                       | 2x compute nodes, nonsequential names
 test2  | 2            | N                       | 4x compute node, sequential names
 test3  | 1            | Y                       | 4x compute nodes in 2x groups, single partition
 test4  | 1            | N                       | 2x compute node, accounting enabled
-test5  | 1            | N                       | As for #1 but configless
-test6  | 1            | N                       | 0x compute nodes, configless
+test5  | -            | -                       | [removed, now always configless]
+test6  | 1            | N                       | 0x compute nodes
 test7  | 1            | N                       | [removed, image build should just run install.yml task, this is not expected to work]
-test8  | 1            | N                       | 2x compute node, 2x login-only nodes, configless
+test8  | 1            | N                       | 2x compute node, 2x login-only nodes
 test9  | 1            | N                       | As test8 but uses `--limit=testohpc-control,testohpc-compute-0` and checks login nodes still end up in slurm.conf
-test10 | 1            | N                       | As for #5 but then tries to add an additional node
-test11 | 1            | N                       | As for #5 but then deletes a node (actually changes the partition due to molecule/ansible limitations)
-test12 | 1            | N                       | As for #5 but enabling job completion and testing `sacct -c`
-test13 | 1            | N                       | As for #5 but tests `openhpc_config` variable.
-test14 | 1            | N                       | [removed, extra_nodes removed]
-test15 | 1            | Y                       | As for #5 but also tests `partitions with different name but with the same NodeName`.
-
+test10 | 1            | N                       | As for #1 but then tries to add an additional node
+test11 | 1            | N                       | As for #1 but then deletes a node (actually changes the partition due to molecule/ansible limitations)
+test12 | 1            | N                       | As for #1 but enabling job completion and testing `sacct -c`
+test13 | 1            | N                       | As for #1 but tests `openhpc_config` variable.
+test14 | -            | -                       | [removed, extra_nodes removed]
+test15 | 1            | Y                       | As for #1 but also tests partitions with different name but with the same NodeName.
 
 # Local Installation & Running
 

molecule/test10/converge.yml

@@ -10,7 +10,6 @@
     openhpc_nodegroups:
       - name: "compute"
     openhpc_cluster_name: testohpc
-    openhpc_slurm_configless: true
   tasks:
     - name: "Include ansible-role-openhpc"
       include_role:

molecule/test10/verify.yml

@@ -32,7 +32,6 @@
         openhpc_nodegroups:
           - name: "compute"
         openhpc_cluster_name: testohpc
-        openhpc_slurm_configless: true
 
 - name: Check modified cluster has 3x nodes
   hosts: testohpc_login

molecule/test11/converge.yml

@@ -14,4 +14,3 @@
         openhpc_nodegroups:
           - name: "compute_orig"
         openhpc_cluster_name: testohpc
-        openhpc_slurm_configless: true

molecule/test11/verify.yml

@@ -29,7 +29,6 @@
         openhpc_nodegroups:
           - name: "compute_new"
         openhpc_cluster_name: testohpc
-        openhpc_slurm_configless: true
 
 - name: Check modified cluster has 1x nodes
   hosts: testohpc_login

molecule/test12/converge.yml

@@ -14,5 +14,4 @@
         openhpc_nodegroups:
           - name: "compute"
         openhpc_cluster_name: testohpc
-        openhpc_slurm_configless: true
         openhpc_slurm_job_comp_type: jobcomp/filetxt

molecule/test13/converge.yml

@@ -10,7 +10,6 @@
     openhpc_nodegroups:
       - name: "compute"
     openhpc_cluster_name: testohpc
-    openhpc_slurm_configless: true
     openhpc_login_only_nodes: 'testohpc_login'
     openhpc_config:
       FirstJobId: 13

molecule/test15/converge.yml

@@ -20,7 +20,6 @@
           Default: false
           AllowAccounts: Group_own_thePartition
     openhpc_cluster_name: testohpc
-    openhpc_slurm_configless: true
   tasks:
     - name: "Include ansible-role-openhpc"
       include_role: