Wherever we use become_user set become: true, keeps the linter happy and maintains functionality

Author: maxstack

ansible/roles/basic_users/tasks/main.yml

@@ -79,7 +79,8 @@
     owner: "{{ item.name }}"
     group: "{{ item.name }}"
     mode: u=rwX,go=
-  # become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ item.name }}"
   loop: "{{ basic_users_users }}"
   loop_control:
     label: "{{ item.name }}"
@@ -95,7 +96,8 @@
     comment: "{{ item.ssh_key_comment | default(item.name) }}"
   vars:
     _ssh_key_type: "{{ item.ssh_key_type | default('ed25519') }}"
-  # become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ item.name }}"
   loop: "{{ basic_users_users }}"
   loop_control:
     label: "{{ item.name }}"
@@ -112,7 +114,8 @@
     manage_dir: false
     key: "{{ item.public_key }}"
     path: ~/.ssh/authorized_keys
-  # become_user: "{{ item.item.name }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ item.item.name }}"
   loop: "{{ _cluster_ssh_keypair.results }}"
   loop_control:
     label: "{{ item.item.name }}"
@@ -129,7 +132,8 @@
     manage_dir: false
     key: "{{ item.public_key }}"
     path: ~/.ssh/authorized_keys
-  # become_user: "{{ item.name }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ item.name }}"
   loop: "{{ basic_users_users }}"
   loop_control:
     label: "{{ item.name }}"

ansible/roles/compute_init/files/compute-init.yml

@@ -84,7 +84,8 @@
 
         - ansible.builtin.meta: end_play
     - name: Check if hostvars exist
-      # become_user: slurm # Commenting out as become_user does not imply become: true
+      become: true
+      become_user: slurm
       ansible.builtin.stat:
         path: "/mnt/cluster/hostvars/{{ ansible_hostname }}/hostvars.yml"
       register: hostvars_stat
@@ -99,7 +100,8 @@
 
         - ansible.builtin.meta: end_play
     - name: Sync /mnt/cluster to /var/tmp
-      # become_user: slurm # Commenting out as become_user does not imply become: true
+      become: true
+      become_user: slurm
       ansible.posix.synchronize:
         src: "/mnt/cluster/"
         dest: "/var/tmp/cluster/"

ansible/roles/filebeat/tasks/install.yml

@@ -11,7 +11,8 @@
   containers.podman.podman_image:
     name: "docker.elastic.co/beats/filebeat-oss"
     tag: "{{ filebeat_version }}"
-  # become_user: "{{ filebeat_podman_user }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ filebeat_podman_user }}"
 
 - name: Reload filebeat unit file # noqa: no-changed-when
   ansible.builtin.command: systemctl daemon-reload # noqa: command-instead-of-module

ansible/roles/mysql/tasks/install.yml

@@ -21,4 +21,5 @@
   containers.podman.podman_image:
     name: docker.io/library/mysql
     tag: "{{ mysql_tag }}"
-  # become_user: "{{ mysql_podman_user }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ mysql_podman_user }}"

ansible/roles/opensearch/tasks/install.yml

@@ -20,7 +20,8 @@
   containers.podman.podman_image:
     name: docker.io/opensearchproject/opensearch
     tag: "{{ opensearch_version }}"
-  # become_user: "{{ opensearch_podman_user }}" # Commenting out as become_user does not imply become: true
+  become: true
+  become_user: "{{ opensearch_podman_user }}"
 
 - name: Reload opensearch unit file # noqa: no-changed-when
   ansible.builtin.command: systemctl daemon-reload # noqa: command-instead-of-module