Skip to content

Commit 42ea541

Browse files
committed
removed redundant checks and made is_callee checking clearer
1 parent 433a9ca commit 42ea541

File tree

3 files changed

+30
-4
lines changed

3 files changed

+30
-4
lines changed

.github/workflows/fatimage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
env:
4747
ANSIBLE_FORCE_COLOR: True
4848
OS_CLOUD: openstack
49-
CI_CLOUD: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.ci_cloud || inputs.ci_cloud_override }}
49+
CI_CLOUD: ${{ github.event.inputs.ci_cloud || inputs.ci_cloud_override }}
5050
ARK_PASSWORD: ${{ secrets.ARK_PASSWORD }}
5151
LEAFCLOUD_PULP_PASSWORD: ${{ secrets.LEAFCLOUD_PULP_PASSWORD }}
5252
outputs:
@@ -61,7 +61,7 @@ jobs:
6161

6262
- uses: actions/checkout@v3
6363
with:
64-
ref: ${{ steps.callee_check.outputs.is_callee && inputs.target_branch || github.ref }}
64+
ref: ${{ steps.callee_check.outputs.is_callee == 'true' && inputs.target_branch || github.ref }}
6565

6666
- name: Record settings for CI cloud
6767
run: |

.github/workflows/stackhpc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656

5757
- uses: actions/checkout@v3
5858
with:
59-
ref: ${{ steps.callee_check.outputs.is_callee && inputs.target_branch || github.ref }}
59+
ref: ${{ steps.callee_check.outputs.is_callee == 'true' && inputs.target_branch || github.ref }}
6060

6161
- name: Override CI_CLOUD if PR label is present
6262
if: ${{ github.event_name == 'pull_request' }}

.github/workflows/update-timestamps.yml

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Check for new Release Train snapshots
22
on:
3-
workflow_dispatch: # temporary, doesn't support workflow_dispatch due to issues with CI_CLOUD in fatimage
3+
workflow_dispatch: # temporary
44
pull_request: #temporary
55
schedule:
66
- cron: '0 7 * * *' # Run at 7am on default branch
@@ -13,6 +13,32 @@ jobs:
1313
steps:
1414
- uses: actions/checkout@v2
1515

16+
- name: test
17+
id: teststep
18+
run: |
19+
echo "TESTING='true'" >> "$GITHUB_OUTPUT""
20+
echo "falsetest='false'" >> "$GITHUB_OUTPUT""
21+
22+
- name: test A
23+
if: ${{ steps.teststep.outputs.TESTING }}
24+
run: |
25+
echo 'hello world'
26+
27+
- name: test B
28+
if: ${{ steps.teststep.outputs.TESTING == 'true' }}
29+
run: |
30+
echo 'hello world'
31+
32+
- name: test C
33+
if: ${{ steps.teststep.outputs.falsetest }}
34+
run: |
35+
echo 'hello world'
36+
37+
- name: test D
38+
if: ${{ steps.teststep.outputs.falsetest == 'false' }}
39+
run: |
40+
echo 'hello world'
41+
1642
- name: Check automation branch exists
1743
id: auto-branch-check
1844
run: |

0 commit comments

Comments
 (0)