Troubleshooting: revert all ansible linting

Author: maxstack

ansible/adhoc/backup-keytabs.yml

@@ -1,12 +1,11 @@
----
 # Use ONE of the following tags on this playbook:
 #   - retrieve: copies keytabs out of the state volume to the environment
 #   - deploy: copies keytabs from the environment to the state volume
 
 - hosts: freeipa_client
-  become: true
-  gather_facts: false
+  become: yes
+  gather_facts: no
   tasks:
-    - ansible.builtin.import_role:
+    - import_role:
         name: freeipa
         tasks_from: backup-keytabs.yml

ansible/adhoc/cudatests.yml

@@ -1,9 +1,8 @@
----
 - hosts: cuda
-  become: true
-  gather_facts: true
+  become: yes
+  gather_facts: yes
   tags: cuda_samples
   tasks:
-    - ansible.builtin.import_role:
+    - import_role:
         name: cuda
         tasks_from: samples.yml

ansible/adhoc/deploy-pulp.yml

@@ -1,27 +1,26 @@
----
 # Usage: ansible-playbook ansible/adhoc/deploy-pulp.yml -e "pulp_server=<pulp server hostname>"
 
 - name: Add temporary pulp server host
   hosts: localhost
   tasks:
-    - ansible.builtin.add_host:
-        name: "{{ pulp_server }}"
-        group: "_pulp_host"
+  - ansible.builtin.add_host:
+      name: "{{ pulp_server }}"
+      group: "_pulp_host"
 
 - name: Install pulp on server and add to config
-  become: true
+  become: yes
   hosts: _pulp_host
   tasks:
-    - name: Install pulp
-      ansible.builtin.include_role:
-        name: pulp_site
-        tasks_from: install.yml
-        public: true
+  - name: Install pulp
+    ansible.builtin.include_role:
+      name: pulp_site
+      tasks_from: install.yml
+      public: true
 
-    - name: Print Pulp endpoint
-      become: false
-      ansible.builtin.debug:
-        msg: |
-          Server configured, override 'appliances_pulp_url' with
-            appliances_pulp_url: "http://{{ pulp_server }}:{{ pulp_site_port }}"
-          in your environments
+  - name: Print Pulp endpoint
+    become: no
+    debug:
+      msg: | 
+        Server configured, override 'appliances_pulp_url' with
+          appliances_pulp_url: "http://{{ pulp_server }}:{{ pulp_site_port }}"
+        in your environments

ansible/adhoc/generate-passwords.yml

@@ -1,8 +1,9 @@
 ---
+
 - name: Generate passwords.yml
   hosts: localhost
   gather_facts: false
   tasks:
     - name: Include password generation role
-      ansible.builtin.include_role:
-        name: passwords
+      include_role:
+        name: passwords

ansible/adhoc/hpctests.yml

@@ -3,9 +3,10 @@
 # Relies on installed packages in appliance defaults - see openhpc variables.
 
 ---
+
 - hosts: hpctests[0] # TODO: might want to make which node is used selectable?
   become: false
   gather_facts: false
   tasks:
-    - ansible.builtin.import_role:
+    - import_role:
         name: hpctests

ansible/adhoc/rebuild-via-slurm.yml

@@ -1,4 +1,3 @@
----
 # Rebuild compute nodes via slurm.
 # Nodes will be rebuilt if `image_id` in inventory is different to the
 # currently-provisioned image. Otherwise they are rebooted.
@@ -10,9 +9,9 @@
 
 - hosts: login
   run_once: true
-  gather_facts: false
+  gather_facts: no
   tasks:
     - name: Run slurm-controlled rebuild
-      ansible.builtin.import_role:
+      import_role:
         name: rebuild
         tasks_from: rebuild.yml

ansible/adhoc/rebuild.yml

@@ -1,24 +1,21 @@
----
 # Rebuild hosts with a specified image from OpenStack.
-#
+# 
 # Use ansible's -v output to see output.
 # Use --limit to control which hosts to rebuild (either specific hosts or the <cluster_name>_<partition_name> groups defining partitions).
 # Optionally, supply `-e rebuild_image=<image_name_or_id>` to define a specific image, otherwise the current image is reused.
 #
-# NOTE: If a hostvar `instance_id` is defined this is used to select hosts.
-#       Otherwise the hostname is used and this must be unique, which may not be the case e.g. if using identically-named staging and production hosts.
+# NOTE: If a hostvar `instance_id` is defined this is used to select hosts. Otherwise the hostname is used and this must be unique, which may not be the case e.g. if using identically-named staging and production hosts.
 #
 # Example:
 #   ansible-playbook -v --limit ohpc_compute ansible/adhoc/rebuild.yml -e rebuild_image=openhpc_v2.3
 
 - hosts: cluster
-  become: false
-  gather_facts: false
+  become: no
+  gather_facts: no
   tasks:
-    # yamllint disable-line rule:line-length
-    - ansible.builtin.command: "openstack server rebuild {{ instance_id | default(inventory_hostname) }}{% if rebuild_image is defined %} --image {{ rebuild_image }}{% endif %}"
+    - command: "openstack server rebuild {{ instance_id | default(inventory_hostname) }}{% if rebuild_image is defined %} --image {{ rebuild_image }}{% endif %}"
       delegate_to: localhost
-      changed_when: false
-    - ansible.builtin.wait_for_connection:
+    - wait_for_connection:
         delay: 60
         timeout: 600
+

ansible/adhoc/restart-slurm.yml

@@ -1,30 +1,29 @@
----
 # Restart all slurm daemons e.g. after changing configuration. Note that:
 # - `scontrol reconfigure` will handle most reconfiguration - see https://slurm.schedmd.com/scontrol.html#OPT_reconfigure
 #   for which options need a restart
 # - Adding or removing nodes by changing the `openhpc_` configuration and rerunning ansible/site.yml will automatically
 #   restart daemons as required.
 
 - hosts: compute,login
-  become: true
-  gather_facts: false
+  become: yes
+  gather_facts: no
   tasks:
-    - ansible.builtin.service:
+    - service:
         name: slurmd
         state: stopped
 
 - hosts: control
-  become: true
-  gather_facts: false
+  become: yes
+  gather_facts: no
   tasks:
-    - ansible.builtin.service:
+    - service:
         name: slurmctld
         state: restarted
 
 - hosts: compute,login
-  become: true
-  gather_facts: false
+  become: yes
+  gather_facts: no
   tasks:
-    - ansible.builtin.service:
+    - service:
         name: slurmd
         state: started

ansible/adhoc/sync-pulp.yml

@@ -1,4 +1,3 @@
----
 - hosts: localhost
   tasks:
     - ansible.builtin.include_role:

ansible/adhoc/update-packages.yml

@@ -1,20 +1,18 @@
----
 - hosts: update
-  become: true
+  become: yes
   gather_facts: false
   tasks:
     - name: Update selected packages
-      ansible.builtin.dnf:
+      yum:
         name: "{{ update_name }}"
         state: "{{ update_state }}"
         exclude: "{{ update_exclude }}"
         disablerepo: "{{ update_disablerepo }}"
       register: updates
     - name: Log updated packages
-      ansible.builtin.copy:
+      copy:
         content: "{{ updates.results | join('\n') }}"
         dest: "{{ update_log_path }}"
-        mode: "0644"
       delegate_to: localhost
-    - ansible.builtin.debug:
+    - debug:
         msg: "{{ updates.results | length }} changes to packages - see {{ update_log_path }} for details"