Fix linting on merge of origin/main

Author: maxstack

.github/bin/get-s3-image.sh

@@ -17,7 +17,7 @@ if [ -n "$image_exists" ]; then
 else
   echo "Image $image_name not found in OpenStack. Getting it from S3."
 
-  wget https://leafcloud.store/swift/v1/AUTH_f39848421b2747148400ad8eeae8d536/$bucket_name/$image_name --progress=dot:giga
+  wget "https://leafcloud.store/swift/v1/AUTH_f39848421b2747148400ad8eeae8d536/$bucket_name/$image_name" --progress=dot:giga
 
   echo "Uploading image $image_name to OpenStack..."
   openstack image create --file "$image_name" --disk-format qcow2 "$image_name" --progress

ansible/bootstrap.yml

@@ -82,7 +82,7 @@
         search_string: HOSTNAME=$(/usr/bin/hostnamectl --transient 2>/dev/null) || \
         state: absent
     - name: Add system user groups
-      ansible.builtin.group: "{{ item.group }}"
+      ansible.builtin.group: "{{ item.group }}" # noqa: args[module]
       loop: "{{ appliances_local_users }}"
       when:
         - item.enable | default(true) | bool
@@ -91,7 +91,7 @@
       # Need to change working directory otherwise we try to switch back to non-existent directory.
       become_flags: "-i"
     - name: Add system users
-      ansible.builtin.user: "{{ item.user }}"
+      ansible.builtin.user: "{{ item.user }}" # noqa: args[module]
       loop: "{{ appliances_local_users }}"
       when: item.enable | default(true) | bool
       become_method: ansible.builtin.sudo

ansible/fatimage.yml

@@ -192,7 +192,7 @@
       when: "'alertmanager' in group_names"
 
     - name: Download HPL source
-      include_role:
+      ansible.builtin.include_role:
         name: hpctests
         tasks_from: source-hpl.yml
 
@@ -207,7 +207,8 @@
     # can't run cloudalchemy.prometheus/tasks/install.yml as it triggers a unit start
     # so below is a partial extraction of this:
     - name: Create prometheus system group
-      ansible.builtin.group: prometheus
+      ansible.builtin.group:
+        name: prometheus
         system: true
         state: present
 
@@ -270,7 +271,7 @@
 
 - name: Add support for NVIDIA GPU auto detection to Slurm
   hosts: slurm_recompile
-  become: yes
+  become: true
   tasks:
     - name: Recompile slurm
       ansible.builtin.import_role:

ansible/portal.yml

@@ -43,10 +43,10 @@
   tags:
     - openondemand
     - openondemand_rstudio
-  become: yes
-  gather_facts: yes
+  become: true
+  gather_facts: true
   tasks:
-    - import_role:
+    - ansible.builtin.import_role:
         name: openondemand
         tasks_from: rstudio_compute.yml
       when: appliances_mode != 'configure' # is run during build
@@ -55,10 +55,10 @@
   tags:
     - openondemand
     - openondemand_codeserver
-  become: yes
-  gather_facts: yes
+  become: true
+  gather_facts: true
   tasks:
-    - import_role:
+    - ansible.builtin.import_role:
         name: openondemand
         tasks_from: codeserver_compute.yml
       when: appliances_mode != 'configure' # is run during build

ansible/roles/alertmanager/README.md

@@ -15,6 +15,7 @@ Alertmanager is enabled by default on the `control` node in the
 `site` environment's `inventory/groups` file.
 
 In general usage may only require:
+
 - Enabling the Slack integration (see section below).
 - Possibly setting `alertmanager_web_external_url`.
 

ansible/roles/alertmanager/tasks/install.yml

@@ -1,6 +1,7 @@
 ---
 - name: Create alertmanager system user
-  ansible.builtin.user: "{{ alertmanager_system_user }}"
+  ansible.builtin.user:
+    name: "{{ alertmanager_system_user }}"
     system: true
     create_home: false
 

ansible/roles/basic_users/tasks/main.yml

@@ -18,11 +18,11 @@
     - basic_users_override_sssd | bool
 
 - name: Create groups
-  ansible.builtin.group: "{{ item }}"
+  ansible.builtin.group: "{{ item }}" # noqa: args[module]
   loop: "{{ basic_users_groups }}"
 
 - name: Create users
-  ansible.builtin.user: "{{ basic_users_userdefaults | combine(item) | filter_user_params() | combine(_disable_homedir) }}"
+  ansible.builtin.user: "{{ basic_users_userdefaults | combine(item) | filter_user_params() | combine(_disable_homedir) }}" # noqa: args[module]
   loop: "{{ basic_users_users }}"
   loop_control:
     label: "{{ item.name }}"

ansible/roles/dnf_repos/defaults/main.yml

@@ -49,7 +49,7 @@ dnf_repos_openhpc_repolist:
     base_url: "{{ dnf_repos_pulp_content_url }}/{{ appliances_pulp_repos.openhpc_updates[ansible_distribution_major_version] | appliances_repo_to_subpath }}"
 
 dnf_repos_extra_repolist: []
-dnf_repos_repolist: "{{ dnf_repos_default_repolist + (dnf_repos_openhpc_repolist if (openhpc_install_type | default('ohpc')) == 'ohpc' else []) + dnf_repos_extra_repolist }}"
+dnf_repos_repolist: "{{ dnf_repos_default_repolist + (dnf_repos_openhpc_repolist if (openhpc_install_type | default('ohpc')) == 'ohpc' else []) + dnf_repos_extra_repolist }}" # noqa: yaml[line-length]
 
 dnf_repos_epel_baseurl: "{{ dnf_repos_pulp_content_url }}/{{ appliances_pulp_repos.epel[ansible_distribution_major_version] | appliances_repo_to_subpath }}"
 dnf_repos_epel_description: "epel"

ansible/roles/hpctests/tasks/build-hpl.yml

@@ -20,6 +20,7 @@
     src: "{{ hpctests_hpl_srcdir }}/setup/Make.Linux_PII_CBLAS"
     dest: "{{ hpctests_hpl_srcdir }}/Make.{{ hpctests_hpl_arch }}"
     remote_src: true
+    mode: "0644"
 
 - name: Modify make file
   ansible.builtin.replace:

ansible/roles/hpctests/tasks/source-hpl.yml

@@ -1,15 +1,16 @@
 ---
 
 - name: Make directory
-  file:
+  ansible.builtin.file:
     path: "/opt/hpl"
     state: directory
     owner: root
     group: root
     mode: '0755'
 
 - name: Download HPL tarball
-  get_url:
+  # checkov:skip=CKV2_ANSIBLE_2: "Ensure that HTTPS url is used with get_url"
+  ansible.builtin.get_url:
     url: "http://www.netlib.org/benchmark/hpl/hpl-{{ hpctests_hpl_version }}.tar.gz"
     dest: "/opt/hpl/hpl-{{ hpctests_hpl_version }}.tar.gz"
     owner: root