Reverting changes made to ansible.builtin.user and ansible.builtin.group where the name parameter was added.

Reverting to ansible.builtin.group: <args>

becasue args aren't an expected label:

groupadd: '{'name': 'grafana', 'gid': 979}' is not a valid group name

Author: maxstack

ansible/bootstrap.yml

@@ -82,8 +82,7 @@
         search_string: HOSTNAME=$(/usr/bin/hostnamectl --transient 2>/dev/null) || \
         state: absent
     - name: Add system user groups
-      ansible.builtin.group:
-        name: "{{ item.group }}"
+      ansible.builtin.group: "{{ item.group }}"
       loop: "{{ appliances_local_users }}"
       when:
         - item.enable | default(true) | bool
@@ -92,8 +91,7 @@
       # Need to change working directory otherwise we try to switch back to non-existent directory.
       become_flags: "-i"
     - name: Add system users
-      ansible.builtin.user:
-        name: "{{ item.user }}"
+      ansible.builtin.user: "{{ item.user }}"
       loop: "{{ appliances_local_users }}"
       when: item.enable | default(true) | bool
       become_method: ansible.builtin.sudo

ansible/fatimage.yml

@@ -202,8 +202,7 @@
     # can't run cloudalchemy.prometheus/tasks/install.yml as it triggers a unit start
     # so below is a partial extraction of this:
     - name: Create prometheus system group
-      ansible.builtin.group:
-        name: prometheus
+      ansible.builtin.group: prometheus
         system: true
         state: present
 

ansible/roles/alertmanager/tasks/install.yml

@@ -1,7 +1,6 @@
 ---
 - name: Create alertmanager system user
-  ansible.builtin.user:
-    name: "{{ alertmanager_system_user }}"
+  ansible.builtin.user: "{{ alertmanager_system_user }}"
     system: true
     create_home: false
 

ansible/roles/basic_users/tasks/main.yml

@@ -18,13 +18,11 @@
     - basic_users_override_sssd | bool
 
 - name: Create groups
-  ansible.builtin.group:
-    name: "{{ item }}"
+  ansible.builtin.group: "{{ item }}"
   loop: "{{ basic_users_groups }}"
 
 - name: Create users
-  ansible.builtin.user:
-    name: "{{ basic_users_userdefaults | combine(item) | filter_user_params() | combine(_disable_homedir) }}"
+  ansible.builtin.user: "{{ basic_users_userdefaults | combine(item) | filter_user_params() | combine(_disable_homedir) }}"
   loop: "{{ basic_users_users }}"
   loop_control:
     label: "{{ item.name }}"

ansible/roles/podman/tasks/configure.yml

@@ -39,8 +39,7 @@
 - name: Reset ssh connection to allow user changes to affect 'current login user'
   ansible.builtin.meta: reset_connection
 - name: Ensure podman users exist
-  ansible.builtin.user:
-    name: "{{ item }}"
+  ansible.builtin.user: "{{ item }}"
   with_items: "{{ podman_users }}"
   register: podman_user_info
   become: true