fix build groups

Author: sjpb

environments/.stackhpc/inventory/extra_groups

@@ -1,3 +1,5 @@
+# Unless noted otherwise features enabled here are tested by CI site.yml playbook
+
 [basic_users:children]
 cluster
 
@@ -20,15 +22,14 @@ cluster
 # --- end of FreeIPA example ---
 
 [manila:children]
-# Allows demo; also installs manila client in fat image
+# Not actully tested but allows demo using this environment
 login
 compute
 
 [chrony:children]
 cluster
 
 [tuned:children]
-# Test tuned during site playbook
 cluster
 
 [rebuild:children]
@@ -39,7 +40,3 @@ cluster
 
 [compute_init:children]
 compute
-
-[gateway:children]
-# Install gateway ansible-init playbook into image
-builder

environments/common/inventory/groups

@@ -1,3 +1,12 @@
+# This file
+# 1. Ensures all groups in the appliance are always defined - even if empty
+# 2. Defines dependencies between groups - child groups require & enables parent
+#
+# IMPORTANT
+# ---------
+# All groups and child groups here MUST be empty, as other environments cannot
+# remove hosts/groups.
+
 [login]
 # All Slurm login nodes. Combined control/login nodes are not supported.
 
@@ -196,10 +205,12 @@ k3s_agent
 
 [dnf_repos:children]
 # Hosts to replace system repos with Pulp repos
+# Roles/groups listed here *always* do installs:
 extra_packages
-cuda
 doca
 
+# what we want to say is if cuda and build, add dnf_repos
+
 [pulp_site]
 # Add builder to this group to automatically sync pulp during image build
 

environments/site/inventory/groups

@@ -156,8 +156,11 @@ fatimage
 [extra_packages:children]
 # Hosts to install specified additional packages on
 
-[dnf_repos]
+[dnf_repos:children]
 # Hosts to replace system repos with Pulp repos
+# Some roles do installs when in install mode/on build VM only:
+fatimage
+builder
 
 [cacerts]
 # Hosts to configure CA certificates and trusts on